-
Notifications
You must be signed in to change notification settings - Fork 7
Upgrade/adminlte bs #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade/adminlte bs #627
Conversation
Removes [pdfmake](https://github.com/bpampuch/pdfmake). It's no longer used after updating ancestor dependency [admin-lte](https://github.com/ColorlibHQ/AdminLTE). These dependencies need to be updated together. Removes `pdfmake` Updates `admin-lte` from 3.2.0 to 4.0.0-rc3 - [Release notes](https://github.com/ColorlibHQ/AdminLTE/releases) - [Changelog](https://github.com/ColorlibHQ/AdminLTE/blob/master/CHANGELOG.md) - [Commits](ColorlibHQ/AdminLTE@v3.2.0...v4.0.0-rc3) --- updated-dependencies: - dependency-name: pdfmake dependency-version: dependency-type: indirect - dependency-name: admin-lte dependency-version: 4.0.0-rc3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrading frontend dependencies from AdminLTE v3 (Bootstrap 4 + jQuery) to AdminLTE v4 (Bootstrap 5) with modern CSS classes and components, while reducing jQuery dependency in preparation for its complete removal.
- Updated package dependencies to AdminLTE v4, Bootstrap 5, and FontAwesome 6
- Replaced jQuery DOM manipulation with native JavaScript in form handling
- Migrated Bootstrap 4 classes and data attributes to Bootstrap 5 equivalents
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
agate.js | Replaced jQuery selectors with native DOM API and updated spinner handling |
signup.ftl | Updated input group structure and button layout for Bootstrap 5 |
signup-with.ftl | Simplified input groups and updated form layout classes |
signin.ftl | Modernized form layout and updated Bootstrap data attributes |
reset-password.ftl | Updated input groups and button classes for Bootstrap 5 |
profile.ftl | Migrated modal attributes, form classes, and icon classes to Bootstrap 5 |
profile-ini.ftl | Updated wrapper classes and icon classes for new layout system |
models/index.ftl | Updated small-box positioning and icon classes |
libs/top-navbar.ftl | Migrated navbar classes and Bootstrap data attributes |
libs/settings.ftl | Added new dependency paths for Bootstrap 5 and updated libraries |
libs/scripts.ftl | Updated script references to use new dependency paths |
libs/navbar-menus-right.ftl | Updated dropdown data attributes for Bootstrap 5 |
libs/head.ftl | Updated CSS references for new dependencies and Bootstrap 5 |
libs/footer.ftl | Updated footer classes and float utilities |
just-registered.ftl | Updated FontAwesome icon classes |
index.ftl | Restructured layout with Bootstrap 5 classes and semantic elements |
forgot-password.ftl | Simplified form layout and updated input groups |
error.ftl | Updated FontAwesome icon classes |
confirm.ftl | Updated input groups and button classes |
authorize.ftl | Updated button and icon classes for Bootstrap 5 |
pom.xml | Updated Maven resource includes for new dependency structure |
package.json | Upgraded to AdminLTE v4 and added individual Bootstrap 5 dependencies |
Files not reviewed (1)
- agate-webapp/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
I will take a look and try to match. |
I have done some changes so the look is a little more closer but AdminLTE 4 colors are no longer the same. We only have a few FTL pages so I'd just leave the new colors and styles and limit the override to the font file. We have two options:
This is more adequate for Mica than Agate with a few FTLs |
In a recent future, we can get rid of jQuery altogether.