chore(deps): upgrade k8s.io/gengo to v2 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate k8s.io/gengo -> k8s.io/gengo/v2 This required copying the extractCommentTags function because it has been deprecated in v2. v2 introduces a new ExtractFunctionStyleCommentTags function, but it has a different interface, so it's just simpler to import the original ExtractCommentTags code which is dependency free. The code generated with this tool in github.com/oauth2-proxy/oauth2-proxy/pkg/apis/options is not affected.
|
Cc: @tuunit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate k8s.io/gengo -> k8s.io/gengo/v2
This required copying the extractCommentTags function because it has been deprecated in v2. v2 introduces a new ExtractFunctionStyleCommentTags function, but it has a different interface, so it's just simpler to import the original ExtractCommentTags code which is dependency free.
The code generated with this tool in
github.com/oauth2-proxy/oauth2-proxy/pkg/apis/options is not affected.
Motivation and Context
Dependencies upgrade
This is a follow-up to other dependencies upgrades in #6, #7, #8.
How Has This Been Tested?
go generatetested in the oauth2-proxy repo: no change in generated files.