Skip to content

Bug/parsed return type #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025
Merged

Bug/parsed return type #650

merged 11 commits into from
May 22, 2025

Conversation

pboling
Copy link
Member

@pboling pboling commented May 21, 2025

v2.0.10 had a regression where the return type of parsed changed to a vanilla Hash. It needs to be an instance of SnakyHash::StringKeyed in order to support the varied downstream use cases.

  • New caboose workflow to run every version of Hashie on the oldest supported & runnable Ruby is an absolute wagon

Fixes #648
Fixes synth/omniauth-microsoft_graph#43

@pboling pboling self-assigned this May 21, 2025
@pboling pboling added this to the v2.0.11 milestone May 21, 2025
@coveralls
Copy link

coveralls commented May 21, 2025

Pull Request Test Coverage Report for Build 15177314078

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 15151844474: 0.0%
Covered Lines: 516
Relevant Lines: 516

💛 - Coveralls

Copy link

Code Coverage

Package Line Rate Branch Rate Health
oauth2 100% 100%
Summary 100% (516 / 516) 100% (170 / 170)

Minimum allowed line rate is 100%

@pboling pboling merged commit ac2d0c9 into main May 22, 2025
37 checks passed
@pboling pboling deleted the bug/parsed-return-type branch May 22, 2025 03:24
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2e3da41) to head (bfcdd89).
Report is 12 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #650   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with Oauth 2.0.10 Version 2.0.10 breaks Microsoft Oauth
2 participants