Skip to content

Conversation

AnimeshA867
Copy link

@AnimeshA867 AnimeshA867 commented Apr 25, 2025

Pull Request Template

Description

Without this change, the extension is not working properly on Gnome 48. I tested it on Gnome 48 Manjaro.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16
Copy link
Collaborator

Totto16 commented Apr 26, 2025

This doesn't seem right, as modalDialog from gnome-shell is not exported as default, but as member, and the types also say, that it is correct, like it is.

I also tested it with gnome-48 from ubuntu, and it works as expected.

@Dantto
Copy link

Dantto commented Jun 1, 2025

i was looking if i was the only with gnome 48 incompatibility, this proyect just sees so cool. is there a way to use this version? im noob jeje

@kron4eg
Copy link

kron4eg commented Jun 18, 2025

This doesn't seem right, as modalDialog from gnome-shell is not exported as default, but as member, and the types also say, that it is correct, like it is.

yeah, even CI error said so.

Copy link

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this patch working by making the change suggested, and also updating the @girs/gnome-shell dependency to 48.0.4.

import type { ExtensionBase } from '@girs/gnome-shell/dist/extensions/sharedInternals';
import { MessageDialogContent } from '@girs/gnome-shell/dist/ui/dialog';
import { ModalDialog } from '@girs/gnome-shell/dist/ui/modalDialog';
import ModalDialog from '@girs/gnome-shell/dist/ui/modalDialog';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import ModalDialog from '@girs/gnome-shell/dist/ui/modalDialog';
import { ModalDialog } from '@girs/gnome-shell/dist/ui/modalDialog';

That module exports a number of different items, but no default export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants