Skip to content

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Dec 31, 2024

Description

chore: add fixed chalk version to dev dependencies, so that gettext-extractor works as expected)

Fixes #331

the reason for this error is:
chalk is no explicit dependency of gettext-extractor, so it just uses it, if it's there, but the runtime check for that only supports chalk < 5.0.0, but some dependencies of dependencies use chalk >= 5.0.0 and so it fails at runtime, by adding a fixed version to our dev dependencies, gettext-extractor uses that

also fixes a few type errors, that were introduced over time and via some external type packages, and bumps patch or minor versions of some dev dependencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16 Totto16 added the bug Something isn't working label Dec 31, 2024
…xtractor works as expected

fixes #331
the reason for this error is:
chalk is no explicit dependency of gettext-extractor, so it just uses it, if it's there, but the runtime check for that only supports  chalk < 5.0.0, but some dependencies of dependencies use chalk >= 5.0.0 and so it fails at runtime, by adding a fixed version to our dev dependencies, gettext-extractor uses that
@Totto16 Totto16 requested a review from oae December 31, 2024 01:05
@Totto16 Totto16 merged commit 49cd32f into master Dec 31, 2024
1 check passed
@Totto16 Totto16 deleted the fix_locale_gen branch February 20, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure during locale build step

2 participants