Fix #331 #332
Merged
Fix #331 #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtractor works as expected fixes #331 the reason for this error is: chalk is no explicit dependency of gettext-extractor, so it just uses it, if it's there, but the runtime check for that only supports chalk < 5.0.0, but some dependencies of dependencies use chalk >= 5.0.0 and so it fails at runtime, by adding a fixed version to our dev dependencies, gettext-extractor uses that
Totto16
force-pushed
the
fix_locale_gen
branch
from
7f321e2 to
50dc735
Compare
Totto16
force-pushed
the
fix_locale_gen
branch
from
7e71cc7 to
e740e02
Compare
oae
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore: add fixed chalk version to dev dependencies, so that gettext-extractor works as expected)
Fixes #331
the reason for this error is:
chalk is no explicit dependency of gettext-extractor, so it just uses it, if it's there, but the runtime check for that only supports chalk < 5.0.0, but some dependencies of dependencies use chalk >= 5.0.0 and so it fails at runtime, by adding a fixed version to our dev dependencies, gettext-extractor uses that
also fixes a few type errors, that were introduced over time and via some external type packages, and bumps patch or minor versions of some dev dependencies
Type of change
Please delete options that are not relevant.
Checklist