Skip to content

Conversation

@QuentiumYT
Copy link
Contributor

Pull Request Template

Description

To overhaul this project, I improved a few things, I split in several commits to make it easy to understand.

The main goal was to update dependencies regarding girs packages and test it. Then I was struggling to use ts-node (or ts-node-esm) so I switched to the well known tsx library. I also migrated everything to eslint 9 so everything is up to date. (Also speed a little bit the CI)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Totto16
Copy link
Collaborator

Totto16 commented Sep 4, 2024

I / We already use the newest @Girs packages in #278 I'll look at the rest and decide from commit to commit, since some might cause some problems, but thank you in the meantime ❤️

@Totto16 Totto16 self-assigned this Sep 4, 2024
@Totto16 Totto16 added the enhancement New feature or request label Sep 4, 2024
@QuentiumYT
Copy link
Contributor Author

Alright no problem, I can always remove some commits or you can cherry pick what you need if you like :) thanks

@QuentiumYT
Copy link
Contributor Author

Hello, would you like to cherry pick some commits? If not feel free to close this pull request :)

@Totto16
Copy link
Collaborator

Totto16 commented Feb 20, 2025

Hello, would you like to cherry pick some commits? If not feel free to close this pull request :)

I'll do that over on #342 , thanks for your work, I'll look over each commit and see which one we might use and which ones not, I'll leave this open, until everything is sorted out.

@Totto16
Copy link
Collaborator

Totto16 commented Feb 20, 2025

I'll close this no, since #342 was merged, thank you for the template / the granular commits ❤️

@Totto16 Totto16 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants