Feature/article search #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ FRONT_BASE_URL=http://localhost:3000 | |||
|
|
|||
| MOCKED_INTEGRATION_DELAYS_ENABLED=true | |||
|
|
|||
| CMS_STRAPI_BASE_URL= | |||
| CMS_STRAPI_BASE_URL=https://strapi-oss.dev.hycom.pl | |||
|
|
||
| class Article { | ||
| label!: string; | ||
| value!: string; |
There was a problem hiding this comment.
let's rename this to url as value does not hint what it's used for
|
|
||
| return ( | ||
| <> | ||
| {label && ( |
There was a problem hiding this comment.
input should always have a label, so rather there should be a prop called labelHidden that hides it visually
Comment on lines
+20
to
+26
| @Auth.Decorators.Roles({ roles: [Auth.Constants.Roles.USER, Auth.Constants.Roles.ADMIN] }) | ||
| getArticleSearchBlock(@Headers() headers: AppHeaders, @Query() query: GetArticleSearchBlockQuery) { | ||
| return this.service.getArticleSearchBlock(query, headers); | ||
| } | ||
|
|
||
| @Get('articles') | ||
| @Auth.Decorators.Roles({ roles: [Auth.Constants.Roles.USER, Auth.Constants.Roles.ADMIN] }) |
There was a problem hiding this comment.
this component should NOT require any roles (currently it prevents it from being rendered before signing-in)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
New block ArticleSearch added