Skip to content

fix: add support for multiple statements in v-on snippets #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

Teages
Copy link
Collaborator

@Teages Teages commented Apr 22, 2025

@Teages Teages requested review from danielroe and Copilot April 22, 2025 15:19
Copy link

pkg-pr-new bot commented Apr 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vue-sfc-transformer@36

commit: e119929

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for multiple statements in v-on snippets, addressing issue nuxt/module-builder#587. Key changes include new tests for v-on multi-statement behavior, an updated Expression track type, and the addition of a multipleStatementsSnippetHandler to handle the transformation of multi-statement expressions.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/template.test.ts Added tests to verify multiple statement support in v-on snippets.
src/utils/template.ts Introduced multipleStatementsSnippetHandler and updated track types.
Files not reviewed (2)
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@danielroe danielroe merged commit 98fdb6a into main Apr 22, 2025
4 checks passed
@danielroe danielroe deleted the fix/multiple-statements-snippet branch April 22, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error location is not displayed
2 participants