Support Laravel 12 #2665
Support Laravel 12 #2665
Conversation
stayallive
force-pushed
the
laravel-12
branch
3 times, most recently
from
b32f75f to
86bd25d
Compare
|
This is shaking out some nasty phpstan stuff, a small part is probably a bug on their side (for php 8.4; phpstan/phpstan-src#3855) but others seems to be related to larastan maybe not correctly detecting the testing mixing. Not sure how to fix this. Tests are passing so it's all working but it looks like phpstan/larastan might not understand some stuff all of a sudden. Quick search on both repo's did not yield any red flags. It might be on their side since only the "highest" dependency phpstan runs are failing (and 8.4 runs because of linked bug). Appreciate a quick look @spawnia since you might know what is going on here or maybe we should just have a little patience and this will resolve itself in a few days 🫣 |
There was a problem hiding this comment.
Thank you @stayallive for tackling this. Regarding the points you brought up:
- Requiring a fork of
dms/phpunit-arraysubset-assertsis fine for now - I have also encountered the detection of mixins to be broken, as seen in mll-lab/laravel-utils#29. Perhaps it will resolve itself once when PHPStan releases phpstan/phpstan-src#3855?
stayallive
force-pushed
the
laravel-12
branch
2 times, most recently
from
3b88876 to
009fdf5
Compare
|
Locally I'm left with 2 errors on PHP 8.4 (from phpstan), CI does not seem to agree with me yet though 🙈 |
# Conflicts: # CHANGELOG.md
Warning: Trying to access array offset on null src/Schema/AST/ASTCache.php:28
# Conflicts: # CHANGELOG.md # src/Tracing/FederatedTracing/Proto/FieldStat.php # src/Tracing/FederatedTracing/Proto/ReportHeader.php # src/Tracing/FederatedTracing/Proto/Trace.php # src/Tracing/FederatedTracing/Proto/Trace/Node.php # src/Tracing/FederatedTracing/Proto/TracesAndStats.php
|
Released with https://github.com/nuwave/lighthouse/releases/tag/v6.54.0. |
|
Thanks @spawnia for taking this over the finish line 🧡 |
Resolves #2662
Changes
Allow Laravel 12 and adjust tests and dependencies where needed.
There are some interesting things.
dms/phpunit-arraysubset-assertsdependency is not yet out for the phpunit we need for L12 and thus I've included the fork with the compatible PR. Since it's adevonly dependency this might be fine for now but should be reverted in the future. It does allow us to move forward at least. It's this PR's code: Add phpunit 11 support rdohms/phpunit-arraysubset-asserts#86laravel/scoutversions since Scout doesn't update its version every time Laravel does, this was probably done in error in previous Laravel version updates.unset.possiblyHookedPropertyphpstan errors is a bug on their side, should be fixed soon-ish: Fix unsetting array item triggers unset.possiblyHookedProperty phpstan/phpstan-src#3855Breaking changes
None. Laravel 12 is also a super simple release for us from what it seems (in the BC department at least).