fix: Align validation with upstream Kubeadm Bootstrap Provider types #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlipovetsky Please run |
The maxLength was too short in some cases, breaking cluster creation. Now, all parameters align with the upstream types.
dlipovetsky
force-pushed
the
issue/fix-maxlength-bootstrap-types
branch
from
598bec7 to
3cf9af2
Compare
|
Ran |
jimmidyson
approved these changes
Oct 7, 2025
|
One test failed due because a DNS lookup failed: |
Merged
dlipovetsky
added a commit
that referenced
this pull request
Oct 7, 2025
🤖 I have created a release *beep* *boop* --- ## 0.35.1 (2025-10-07) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: Remove Cilium chainingMode when kubeproxyreplacement is enabled by @supershal in #1340 * fix: Align validation with upstream Kubeadm Bootstrap Provider types by @dlipovetsky in #1342 ### Other Changes * refactor: move handler directories by @dkoshkin in #1321 **Full Changelog**: v0.35.0...v0.35.1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
…1342) **What problem does this PR solve?**: The maxLength was too short in some cases, breaking cluster creation. Now, all parameters align with the upstream types. **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-110334 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
🤖 I have created a release *beep* *boop* --- ## 0.35.1 (2025-10-07) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: Remove Cilium chainingMode when kubeproxyreplacement is enabled by @supershal in #1340 * fix: Align validation with upstream Kubeadm Bootstrap Provider types by @dlipovetsky in #1342 ### Other Changes * refactor: move handler directories by @dkoshkin in #1321 **Full Changelog**: v0.35.0...v0.35.1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
The maxLength was too short in some cases, breaking cluster creation. Now, all parameters align with the upstream types.
Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-110334
How Has This Been Tested?:
Special notes for your reviewer: