Skip to content

feat(preflight): Storage container checks for Nutanix #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 23, 2025
Merged

feat(preflight): Storage container checks for Nutanix #1136

merged 5 commits into from
Jun 23, 2025

Conversation

thunderboltsid
Copy link
Contributor

Add pre-flight checks to ensure the storage container mentioned in CSI Provider storage class config parameters is present in all relevant AOS clusters i.e. control plane and workers.

@dlipovetsky dlipovetsky force-pushed the dlipovetsky/preflight-nutanix-vmimage branch from 82699cd to 01bb8ce Compare May 30, 2025 15:58
@dlipovetsky
Copy link
Contributor

I'll resolve the conflicts.

@thunderboltsid
Copy link
Contributor Author

I'll resolve the conflicts.

no worries; it was easy enough to rebase on your changes.

@thunderboltsid thunderboltsid force-pushed the jira/NCN-105203 branch 2 times, most recently from 1ffbc7b to 8194df5 Compare June 2, 2025 15:56
@dlipovetsky dlipovetsky force-pushed the dlipovetsky/preflight-nutanix-vmimage branch 2 times, most recently from fb9d8a1 to f0cb9f8 Compare June 3, 2025 17:30
@thunderboltsid thunderboltsid force-pushed the jira/NCN-105203 branch 3 times, most recently from 10da176 to 442c703 Compare June 4, 2025 17:02
@dlipovetsky
Copy link
Contributor

Surprising e2e failure:

Failed to get the list of Storage Container due to - Error encountered while getting Storage Container Entities.

@dlipovetsky dlipovetsky force-pushed the dlipovetsky/preflight-nutanix-vmimage branch from ca0bc94 to f440ff1 Compare June 6, 2025 04:51
@dlipovetsky
Copy link
Contributor

I made further changes to #1130, and I rebased this again. I also added unit tests.

@dlipovetsky
Copy link
Contributor

Surprising e2e failure:

Failed to get the list of Storage Container due to - Error encountered while getting Storage Container Entities.

I found the cause and fixed it. The filter was using double quotes, but the API requires single quotes.

@dlipovetsky
Copy link
Contributor

Sorry about the new code churn. I'll resolve the conflicts soon.

@dlipovetsky dlipovetsky force-pushed the dlipovetsky/preflight-nutanix-vmimage branch from 6ab50f2 to 93299d2 Compare June 13, 2025 20:32
@dlipovetsky dlipovetsky requested a review from faiq June 16, 2025 16:57
@dlipovetsky dlipovetsky force-pushed the dlipovetsky/preflight-nutanix-vmimage branch from 93299d2 to 365033c Compare June 17, 2025 15:47
@dlipovetsky
Copy link
Contributor

I'll rebase on main after #1130 merges.

@dlipovetsky dlipovetsky force-pushed the dlipovetsky/preflight-nutanix-vmimage branch from 97075a2 to ed9b787 Compare June 17, 2025 20:05
Base automatically changed from dlipovetsky/preflight-nutanix-vmimage to main June 17, 2025 20:33
@github-actions github-actions bot removed the feature label Jun 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025 •
edited
Loading

Automated PR Comment From Black Duck SCA

❌ Found dependencies violating policy!

Policies Violated Dependency License(s) Vulnerabilities Short Term Recommended Upgrade Long Term Recommended Upgrade Resolved / Filtered Out
Unknown github.com/samber/lo (github.com/samber/lo:v1.51.0) Unknown License ✅

@dlipovetsky dlipovetsky requested a review from dkoshkin June 17, 2025 20:41
dkoshkin
dkoshkin reviewed Jun 17, 2025
View reviewed changes
dkoshkin
dkoshkin approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks look good. @dlipovetsky is more familiar with the structure of the checks so I will leave it up to him to comment on that.

thunderboltsid and others added 4 commits June 18, 2025 15:24
@thunderboltsid @dlipovetsky
feat(preflight): Add a check for storage containers
3e1edfb 
Add pre-flight checks to ensure the storage container mentioned in CSI Provider
storage class config parameters is present in all relevant AOS clusters
i.e. control plane and workers.

Co-authored-by: Daniel Lipovetsky <daniel.lipovetsky@nutanix.com>
@dlipovetsky
fixup! feat(preflight): Add a check for storage containers
20ac8e9 
Update for latest changes in base branch
@dlipovetsky
fixup! feat(preflight): Add a check for storage containers
85226e4 
Only create checks if client is initialized
@dlipovetsky
fixup! feat(preflight): Add a check for storage containers
85b4422 
Remove stale comment
@dlipovetsky
Copy link
Contributor

I rebased to resolve the merge conflicts (go.mod/sum).

@thunderboltsid thunderboltsid enabled auto-merge (squash) June 19, 2025 21:55
@thunderboltsid thunderboltsid merged commit 3ef53dc into main Jun 23, 2025
23 checks passed
@thunderboltsid thunderboltsid deleted the jira/NCN-105203 branch June 23, 2025 16:45
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Merged
supershal added a commit that referenced this pull request Jun 24, 2025
@jimmidyson @github-actions @supershal
release(main): v0.30.0 (#1171)
022b848 
🤖 I have created a release *beep* *boop*
---


## 0.30.0 (2025-06-24)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Build with Go 1.24.4 to fix CVEs by @jimmidyson in
#1157
* feat: add requests and limits to registry containers by @dkoshkin in
#1158
* feat: Add preflight checks framework by @dlipovetsky in
#1129
* feat: Preflight check opt-out by @dlipovetsky in
#1156
* feat: Nutanix VM image preflight check by @dlipovetsky in
#1130
* feat: update addons by @dkoshkin in
#1168
* feat: Enforce MD replicas within cluster autoscaler bounds by
@jimmidyson in
#1169
* feat(preflight): Storage container checks for Nutanix by
@thunderboltsid in
#1136
* feat: update Nutanix CSI to 3.3.4 by @dkoshkin in
#1179
### Fixes 🔧
* fix: update CNCF registry version to 2.3.4, app version 2.8.3 by
@dkoshkin in
#1150
* fix: registry addon headless service port by @dkoshkin in
#1159
* fix: preserve registry addon root CA on move by @dkoshkin in
#1155
* fix: Add noderegistration patch to previous handler by @jimmidyson in
#1177
### Other Changes
* build: include regclient/regsync image for registry addon by @dkoshkin
in
#1148
* test: Add update test helpers by @jimmidyson in
#1162
* test(e2e): Nutanix 1.33.1 testing by @jimmidyson in
#1164
* build: Update all tools by @jimmidyson in
#1165
* refactor: add global feature.Gates variable by @dkoshkin in
#1167
* ci: new env variable to set --feature-gates by @dkoshkin in
#1166
* build: github.com/hashicorp/go-retryablehttp@v0.7.8 to fix CVE by
@jimmidyson in
#1170
* docs: Update link to default Cilium values in cni.md by
@yannickstruyf3 in
#1173
* docs: Fix up Cilium config link (again) & icons by @jimmidyson in
#1176

## New Contributors
* @yannickstruyf3 made their first contribution in
#1173

**Full Changelog**:
v0.29.0...v0.30.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shalin Patel <shalin.patel@nutanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky dlipovetsky approved these changes

@dkoshkin dkoshkin dkoshkin approved these changes

@faiq faiq Awaiting requested review from faiq

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thunderboltsid @dlipovetsky @dkoshkin