ENH: NPV: Move npv to Cython #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation now shows "broadcasting" behaviour
This follows the existing behaviour of NPV and the precedence set by ufuncs.
This avoids the potential bug of testing the functions in NumPy's namespace, not NumPy-Financial's.
Kai-Striega
added
enhancement
|
Closing this as I've decided on going with Numba, rather than Cython. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Cython support for the Net Present Value (NPV) function.
There is still some work left to do, namely, I'm struggling to configure the build system to work with Poetry. It may be worth moving back to conda and set it up in the usual way instead.