Nufacet resolved input map enhancement #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmassaoy
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
integration/sparkmodule, focusing on enhancing the functionality of theNuFacetclass and adding utility methods for configuration handling. The most important changes include updating the.gitignorefile, modifying theNuFacetclass to include new properties and methods, and adding a new utility classNuFacetsUtils.Enhancements to
NuFacetclass:integration/spark/shared/src/main/java/io/openlineage/spark/agent/facets/NuFacet.java: Added new propertiesresolvedInputsand methodsgetJobNurnandgetResolvedInputsto handle job-related information and inputs.Addition of utility methods:
integration/spark/shared/src/main/java/io/openlineage/spark/agent/util/NuFacetsUtils.java: Introduced a new utility classNuFacetsUtilswith methodsparseJsonToMapandgetConfigValuefor JSON parsing and configuration retrieval.Update to
.gitignore:integration/spark/.gitignore: Addedintegration/spark/docker/notebooks/to the.gitignorefile to exclude the notebooks directory from version control.