Skip to content

use default ports for neogo endpoints #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

532910
Copy link
Contributor

@532910 532910 commented Jul 4, 2024

port is not required more

Signed-off-by: Sеrgiо Nеmirоwski <sergio@nspcc.io>
@532910 532910 requested a review from roman-khimov July 4, 2024 15:07
@carpawell
Copy link
Member

Missing ports looks like smth that should return some HTML page to me. I feel it weird, do you have some common examples when a public service allows skipping port specifying?

@532910
Copy link
Contributor Author

532910 commented Jul 16, 2024

let's do it vice versa: do you have some common examples when a public service port must be specified?

@AnnaShaleva
Copy link
Member

Vote down from my side, status.fs is the last source of truth for me to check on various ports of our nodes.

@carpawell
Copy link
Member

@532910, i meant some services that are not REST. I thought about it like e.g. about a mail server. However, i have thought about it one more time and maybe JSON RPC is closer to a "public HTTP API" than i thought. IDK, i am kinda neutral.

@532910
Copy link
Contributor Author

532910 commented Jul 16, 2024

status.fs is the last source of truth for me to check on various ports of our nodes.

what exactly would you like to check and why do you need it?

@roman-khimov
Copy link
Member

We don't have a clear agreement on the need of this change. But we have a tradition and well-known port numbers for P2P-HTTP-HTTPS services that are expected from the node. These ports are being used, that's what services listen to, so it's OK to have these ports exposed to the public. Therefore, NACK on this one.

@roman-khimov roman-khimov deleted the use-default-ports branch July 16, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants