Skip to content

Upgrade to use searchv2 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025
Merged

Conversation

mike-petrov
Copy link
Contributor

closes #234

Signed-off-by: Mikhail Petrov mike@nspcc.ru

@mike-petrov mike-petrov requested a review from roman-khimov May 6, 2025 16:50
@mike-petrov mike-petrov self-assigned this May 6, 2025
@mike-petrov
Copy link
Contributor Author

npm tests (18.x): This is a scheduled Ubuntu 20.04 retirement. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101

@mike-petrov
Copy link
Contributor Author

mike-petrov commented May 6, 2025

I didn't manage to support tree structure as before: previously, we had FileName attribute for all objects and you could also specify FilePath by which objects were displayed in the tree structure.

Right now, only fields you explicitly specify are being sent. It's ok for required fields, but it's a problem for optional ones because they don't get included at all.

I see two options here: either make the FilePath field mandatory (then we will keep the tree structure, but lose access to files that do not have this attribute), or remove tree structure and show all files in one list, like now:

initial:
Screenshot 2025-05-06 at 18 36 11

filtered:
Screenshot 2025-05-06 at 18 35 35

second page:
Screenshot 2025-05-06 at 19 18 37

@roman-khimov
Copy link
Member

These can be separate views. NeoFS is flat object storage by definition, so the default can be a list based on OIDs/attributes of any kind. Then some toggle can switch us to a tree view, but with a note that only objects with "FilePath" attribute are gonna be shown. It's OK, we're presenting raw NeoFS functionality here more than trying to create any polished object management UI like some other projects.

@mike-petrov mike-petrov force-pushed the feature/234-implement_searchv2 branch from 1cf869a to 384538a Compare May 26, 2025 18:33
@mike-petrov mike-petrov requested a review from roman-khimov May 26, 2025 18:33
@mike-petrov
Copy link
Contributor Author

tree view / list view button:

Screenshot 2025-05-26 at 21 00 14 Screenshot 2025-05-26 at 21 00 31

@mike-petrov mike-petrov force-pushed the feature/234-implement_searchv2 branch from e9db7c9 to 045dcf6 Compare May 26, 2025 18:36
@mike-petrov mike-petrov force-pushed the feature/234-implement_searchv2 branch from 045dcf6 to a8c0569 Compare June 4, 2025 14:21
so that users understands which version of api is used in which function

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the feature/234-implement_searchv2 branch from a8c0569 to ba8a84c Compare June 4, 2025 14:22
@mike-petrov mike-petrov requested a review from roman-khimov June 4, 2025 14:23
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
closes #234

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the feature/234-implement_searchv2 branch from ba8a84c to b94c608 Compare June 20, 2025 16:01
@roman-khimov roman-khimov merged commit d914e5e into master Jun 20, 2025
3 checks passed
@roman-khimov roman-khimov deleted the feature/234-implement_searchv2 branch June 20, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to searchv2
2 participants