Store object tags as attributes along with a payload #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallhive
force-pushed
the
1153-extend-tag-storage-scheme
branch
from
1054a36 to
5100e11
Compare
api/layer/tagging.go
Outdated
| ) | ||
|
|
||
| if isEmptyVersion || isNullVersion { | ||
| versions, _, _, err := n.comprehensiveSearchAllVersionsInNeoFS(ctx, bktInfo, n.Owner(ctx), name, isNullVersion) |
There was a problem hiding this comment.
Additional searches can and should be avoided.
There was a problem hiding this comment.
Do you suggest searching all object versions + all meta objects for this version inside GetObjectTagging. Then filter out the required data in the code? Is it cheaper than two searches?
It is a responsibility of #1158 |
|
I mean deleting tags of an object that had them set on put. |
smallhive
force-pushed
the
1153-extend-tag-storage-scheme
branch
from
5100e11 to
7c2d530
Compare
|
I consider you mean this about tag removing. |
Closes #1153. Put object tags, inside tags-meta object attributes, would help to make tag based searches in the future. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive
force-pushed
the
1153-extend-tag-storage-scheme
branch
from
7c2d530 to
39365be
Compare
roman-khimov
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1153.
It would help to make tag based searches in the future.