Search refactorings #1157
Merged
Search refactorings #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
force-pushed
the
search-optimizations
branch
3 times, most recently
from
d1539f0 to
2eade6e
Compare
It makes zero sense, we only need one object to satisfy condition here. Signed-off-by: Roman Khimov <roman@nspcc.ru>
No functional changes. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Unify logging and cache handling at the same time. Signed-off-by: Roman Khimov <roman@nspcc.ru>
I believe delete marker is not a correct expected result in this case, it's 404 semantically, so it should be returned. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
search-optimizations
branch
from
a1ac795 to
012b4ec
Compare
smallhive
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code simplification.