Stabilize test #1132
Merged
Stabilize test #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 25.77% 25.77%
=======================================
Files 89 89
Lines 15572 15575 +3
=======================================
+ Hits 4013 4014 +1
- Misses 11103 11105 +2
Partials 456 456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
- Commit message formatting is weird
- Unstable TestObjectsListCache/lifetime #1130 isn't mentioned.
- Looks like the test is inherently racy, but OK.
Closes #1130. Sometimes, the runtime took a bit more time, and data was wiped out from the cache. Therefore, sometimes we get nil from the condition. We reduced the condition check for 1 second to ensure we had no nil result for the Never check. Simultaneously, we increased Eventually check interval. This condition checks that the cache is going to be empty during these two seconds. In one second and a few milliseconds in fact. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive
force-pushed
the
fix-test-with-cache
branch
from
bb7304a to
b3ca4df
Compare
|
Updated |
roman-khimov
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the runtime took a bit more time, and data was wiped out from the cache. Therefore, sometimes we get nil from the condition. We reduced the condition check for 1 second to ensure we had no nil result for the Never check. Simultaneously, we increased Eventually check interval. This condition checks that the cache is going to be empty during these two seconds. In one second and a few milliseconds in fact.