Skip to content

Document objectattribute mapping #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

Document objectattribute mapping #1119

merged 2 commits into from
Apr 11, 2025

Conversation

smallhive
Copy link
Contributor

Closes #1115

@smallhive smallhive requested a review from roman-khimov as a code owner April 4, 2025 10:44
roman-khimov
roman-khimov reviewed Apr 8, 2025
View reviewed changes
docs/attribute_mapping.md

### `s3mpUpload`

Stores the multipart upload ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a meta header for Part object

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

docs/attribute_mapping.md
- `s3MetaType: bucketSettings`
- `s3bsVersioning`

The object payload contains the settings data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

docs/attribute_mapping.md

- `s3MetaType: bucketNotifConf`

The object payload contains the configuration data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@smallhive
*: Move S3 object attributes to one place
12bc139 
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 1115-document-objectattribute-mapping branch from 02259f4 to bd23018 Compare April 9, 2025 09:38
@smallhive smallhive requested a review from roman-khimov April 9, 2025 09:38
@smallhive
*: Document S3 object attributes
a3623d5 
Closes #1115.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 1115-document-objectattribute-mapping branch from bd23018 to a3623d5 Compare April 11, 2025 09:13
roman-khimov
roman-khimov approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be improved.

@roman-khimov roman-khimov merged commit 0b2d5dc into master Apr 11, 2025
18 checks passed
@roman-khimov roman-khimov deleted the 1115-document-objectattribute-mapping branch April 11, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document object/attribute mapping
2 participants
@smallhive @roman-khimov