Skip to content

Migrate to aws sdk v2 #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

Migrate to aws sdk v2 #1113

merged 5 commits into from
Apr 14, 2025

Conversation

smallhive
Copy link
Contributor

@smallhive smallhive commented Apr 2, 2025

Tested with the latest versions:

boto3                     1.37.24
botocore                  1.37.24
aws-cli/2.25.3

@smallhive smallhive requested a review from roman-khimov as a code owner April 2, 2025 09:04
@smallhive smallhive force-pushed the 1028-migrate-to-aws-sdk-v2 branch from ab2cfc3 to 9fe3577 Compare April 2, 2025 12:33
@smallhive smallhive linked an issue Apr 3, 2025 that may be closed by this pull request
@smallhive smallhive force-pushed the 1028-migrate-to-aws-sdk-v2 branch 2 times, most recently from ffc3e9b to a7f3cab Compare April 4, 2025 10:50
@smallhive smallhive force-pushed the 1028-migrate-to-aws-sdk-v2 branch from a7f3cab to e720f27 Compare April 11, 2025 09:21
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 1.44928% with 272 lines in your changes missing coverage. Please review.

Project coverage is 25.77%. Comparing base (fcb4791) to head (e720f27).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
api/auth/signer/v4/chunked_reader.go 0.00% 157 Missing ⚠️
api/auth/center.go 3.22% 60 Missing ⚠️
api/auth/signer/v4/checksum_algorithm.go 0.00% 45 Missing ⚠️
api/handler/multipart_upload.go 33.33% 3 Missing and 1 partial ⚠️
api/auth/signer/v4/chunk_signer.go 0.00% 2 Missing ⚠️
api/auth/signer/v4/stream.go 0.00% 2 Missing ⚠️
api/layer/detector.go 0.00% 0 Missing and 1 partial ⚠️
api/layer/multipart_upload.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   26.00%   25.77%   -0.24%     
==========================================
  Files          88       89       +1     
  Lines       15420    15572     +152     
==========================================
+ Hits         4010     4013       +3     
- Misses      10953    11103     +150     
+ Partials      457      456       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smallhive smallhive requested a review from roman-khimov April 11, 2025 09:24
Closes #1028.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
The documentation says the header is required, but even new aws cli (aws-cli/2.25.3) don't send this header any more. Moreover, we even don't check it.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Using state machine simplifies reader logic. It makes possible to extend its logic in the future in a more simple and predictable way.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 1028-migrate-to-aws-sdk-v2 branch from e720f27 to 3318c97 Compare April 11, 2025 13:19
Closes #1059.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 1028-migrate-to-aws-sdk-v2 branch from 3318c97 to 11a66f0 Compare April 14, 2025 07:01
@roman-khimov roman-khimov merged commit 13dc8bb into master Apr 14, 2025
18 checks passed
@roman-khimov roman-khimov deleted the 1028-migrate-to-aws-sdk-v2 branch April 14, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDK v2
2 participants