-
Notifications
You must be signed in to change notification settings - Fork 15
Migrate to aws sdk v2 #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Migrate to aws sdk v2 #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab2cfc3
to
9fe3577
Compare
Closed
ffc3e9b
to
a7f3cab
Compare
a7f3cab
to
e720f27
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
- Coverage 26.00% 25.77% -0.24%
==========================================
Files 88 89 +1
Lines 15420 15572 +152
==========================================
+ Hits 4010 4013 +3
- Misses 10953 11103 +150
+ Partials 457 456 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #1028. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
The documentation says the header is required, but even new aws cli (aws-cli/2.25.3) don't send this header any more. Moreover, we even don't check it. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Using state machine simplifies reader logic. It makes possible to extend its logic in the future in a more simple and predictable way. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
e720f27
to
3318c97
Compare
Closes #1059. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
3318c97
to
11a66f0
Compare
roman-khimov
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with the latest versions: