handlers: fix panic in search, fix #300 #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic in the search functionality by removing redundant deduplication logic for requested attributes.
- Removed code that created a deduplicated attribute list (searchHeader)
- Updated calls and loops to use searchFilters.Attributes directly
Comments suppressed due to low confidence (1)
handlers/objects.go:477
- The removal of the deduplication code (using searchHeader) appears intentional per the commit message; please confirm that passing searchFilters.Attributes directly meets the API's requirements for attribute ordering and uniqueness.
searchHeader = filters[0].Header()
|
What is wrong with the tests? |
This logic adds an implicit first attribute if it's missing from the original request. It assumes that there is always at least one filter present which is no longer true after 706d7d4. Now the code is adjusted for that. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
panic-search
branch
from
ca083ec to
283de8f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a panic in the search functionality by revising how attributes are processed and ensuring proper initialization. Key changes include:
- Initializing returningAttributes with additional capacity.
- Declaring and assigning searchHeader only when filters are available.
- Adjusting how attributes are appended to returningAttributes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
=========================================
- Coverage 9.01% 9.00% -0.01%
=========================================
Files 22 22
Lines 5593 5597 +4
=========================================
Hits 504 504
- Misses 5054 5058 +4
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
706d7d4 made this logic (that tried to deduplicate requested attributes) completely irrelevant.