Org-wide linter #48
Merged
Org-wide linter #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds Makefile target for local linting. Signed-off-by: Roman Khimov <roman@nspcc.ru>
pkg/locodedb/calls_test.go:72:2 whitespace unnecessary trailing newline Signed-off-by: Roman Khimov <roman@nspcc.ru>
pkg/locodedb/utils.go:63:6 errorlint comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error pkg/locodedb/utils.go:87:6 errorlint comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
carpawell,
cthulhu-rider and
AliceInHunterland
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 28.75% 28.75%
=======================================
Files 21 21
Lines 793 793
=======================================
Hits 228 228
Misses 540 540
Partials 25 25 ☔ View full report in Codecov by Sentry. |
End-rey
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.