-
Notifications
You must be signed in to change notification settings - Fork 0
Implement of searchv2 to fetch batch of blocks #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37400df
to
10d4276
Compare
It's known, there are duplicates. Code should handle this. |
3e66a42
to
bc9c3f0
Compare
@roman-khimov everything works now, asynchronously, but because of duplicates I can't understand from which number I should request a search: i.e. if I specify the interval 1000-2700, then we take first 1000 objects with 50 duplicates, and the second search request will start from 2000, while it should start from 1950, how to solve this situation? |
By using the answer you have from the first request? What's the problem, really? You know the last block-oid pair after every request, you don't need to have perfect 1000 blocks. |
Yes, I have 1000 blocks every time, but if there is a duplicate among them, I will not know about it at the asynchronous search stage and will skip it:
At this point we missed block number 1000 because of the duplicate
|
get 995-1990, what's the problem? You know where to start from right after the first search. |
If I immediately request the last block, then yes - I'll know which number is the last, is that what we want to do? |
df00c70
to
00bba73
Compare
ok, now it works |
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
f453dfb
to
3a07ad6
Compare
closes #34
Signed-off-by: Mikhail Petrov mike@nspcc.ru