Skip to content

Initial version #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Initial version #3

merged 5 commits into from
Feb 7, 2025

Conversation

mike-petrov
Copy link
Contributor

closes #1

Signed-off-by: Mikhail Petrov mike@nspcc.ru

@mike-petrov mike-petrov self-assigned this Jan 16, 2025
@mike-petrov
Copy link
Contributor Author

Screenshot 2025-01-16 at 20 39 26 Screenshot 2025-01-16 at 20 39 49 Screenshot 2025-01-16 at 20 41 31

@mike-petrov
Copy link
Contributor Author

mike-petrov commented Jan 16, 2025

@roman-khimov first working version above, now I'm doing streaming file downloads in the background with no memory load.

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
Follows send.fs.neo.org mostly.

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch 2 times, most recently from 44cafcd to 422263c Compare January 23, 2025 16:22
@mike-petrov
Copy link
Contributor Author

image image image

@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from ad9a26d to e5b9728 Compare January 23, 2025 16:41
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Min/max do not read well, we need something like "the latest available block is XXX" dependent on the network.

Downloading the full set should be like opening up the page and hitting one button, that is 0 and the latest should be pre-filled (on network switch)

Browser limitations should be clearly explained, IIRC Firefox can't do this because it doesn't support appropriate API.

Some "About" can be useful as well explaining how it works similar to how send.fs.neo.org has it.

@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from e408862 to 6693f0f Compare January 31, 2025 21:45
Follows send.fs.neo.org mostly.

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from 6693f0f to 979cde4 Compare January 31, 2025 21:52
@mike-petrov
Copy link
Contributor Author

image image image


await writableStream.close();
} catch (error: any) {
if (error.message.indexOf('showSaveFilePicker is not a function') !== -1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to see about from a "bad" browser.

@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from 979cde4 to 3476360 Compare February 5, 2025 16:02
@mike-petrov
Copy link
Contributor Author

Added retry option:

image

@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from 3476360 to 5bc1a0a Compare February 7, 2025 09:20
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the feature/1-initial_version branch from 5bc1a0a to eeceaf6 Compare February 7, 2025 11:36
@roman-khimov roman-khimov merged commit 9b070c2 into master Feb 7, 2025
2 checks passed
@roman-khimov roman-khimov deleted the feature/1-initial_version branch February 7, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial version
2 participants