Skip to content

Deactivate the end block changing if search isnt finished #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

mike-petrov
Copy link
Contributor

Signed-off-by: Mikhail Petrov mike@nspcc.ru

closes #23

@mike-petrov mike-petrov self-assigned this Mar 31, 2025
@roman-khimov
Copy link
Member

Then if it delays for 10s the user can't enter anything? What's the timeout for it?

@mike-petrov
Copy link
Contributor Author

@roman-khimov I checked, if the user has time to enter something before the last block arrives, his data will be erased, but the query seems to take very little time and I rarely have time to type anything in.

@mike-petrov
Copy link
Contributor Author

I don't know the right way to do it, user should see the max value anyway

maybe we should lock input before loading height?

@roman-khimov
Copy link
Member

It can fail as well. You can just not update the field is it's changed from its zero value.

closes #23

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the fix/23-deactivate_end_block_changing branch from 7e622bb to 18082df Compare March 31, 2025 16:26
@roman-khimov roman-khimov merged commit aac2a64 into master Mar 31, 2025
2 checks passed
@roman-khimov roman-khimov deleted the fix/23-deactivate_end_block_changing branch March 31, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivate the end block changing if search isnt finished
2 participants