Write scalars without type information (#1499) #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy 2.x changed the representation of scalaras including type
information. That lead to failing tests, since the test files were
written with the new representation (e.g. `np.int64(0)`).
This reverts to the old behavior of using plain `0`. Though, the actual
fix is likely to use `str()` or `f"{scalar!s}"` as described in the
release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.x changed the representation of scalaras including type
information. That lead to failing tests, since the test files were
written with the new representation (e.g.
np.int64(0)).This reverts to the old behavior of using plain
0. Though, the actualfix is likely to use
str()orf"{scalar!s}"as described in therelease notes.