-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(gradle): add verbose logging flag specifically for gradle plguin #33049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
View your CI Pipeline Execution ↗ for commit de86222
☁️ Nx Cloud last updated this comment at |
fe0337f
to
1e5ba54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The documentation task (@nx/nx-source:documentation) regenerated documentation files and detected changes, reporting that documentation needs to be committed. However, examining the PR diff reveals that these exact documentation changes are already included in the PR commits:
Changed files reported by the task:
- CreateNodes.md, CreateNodesContext.md, CreateNodesFunction.md (deleted)
- CreateNodesContextV2.md, CreateNodesV2.md, NxPluginV2.md, ProjectConfiguration.md, README.md, createNodesFromFiles.md (modified)
These same files appear in the PR diff with identical changes. The author has correctly included the generated documentation updates alongside their code changes to the Gradle plugin.
The failure is classified as 'environment_state' because:
- The documentation changes are already committed in the PR
- The CI environment is running the documentation generation task in a way that doesn't recognize the existing commits
- This could be due to the task running against a detached HEAD, a stale cache, or checking against an incorrect baseline
- No similar failures were found on the master branch, suggesting this is not a systemic issue
- The actual code change (replacing NX_VERBOSE_LOGGING with NX_GRADLE_VERBOSE_LOGGING in the Gradle plugin) is correct and complete
The PR author has followed the correct workflow by generating and committing documentation changes. The task failure appears to be a false positive from the CI environment's validation logic.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
1e5ba54
to
de86222
Compare
#33049) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `NX_VERBOSE_LOGGING` turns on/off the debug logs for the gradle plugin ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `NX_GRADLE_VERBOSE_LOGGING` turns on/off the debug logs for the gradle plugin ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit ffe85e9)
Current Behavior
NX_VERBOSE_LOGGING
turns on/off the debug logs for the gradle plugin. There are some issues with the gradle plugin under heavy volumes of logs. Since gradle logs are much more verbose than Nx logs, this flag allows for finer control of which logs appear.Expected Behavior
NX_GRADLE_VERBOSE_LOGGING
turns on/off the debug logs for the gradle pluginRelated Issue(s)
Fixes #