-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): split slow e2e tests - ng-add, cypress, eslint linter, a… #33012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nd affected-graph Split the following test suites into smaller, more focused tests: - ng-add tests (cypress v9/v10, eslint, generate workspace, multiple projects) - cypress tests (component testing for Angular and Next, e2e execution, app generation) - eslint linter tests (dependency checks, flat config, linting errors, module boundaries, root configs) - affected-graph tests (affected star, focus/exclude, html/json output, show projects, git integration)
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
View your CI Pipeline Execution ↗ for commit e40e2c3
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
); | ||
expect(runCLI(`run ${appName}:e2e`)).toContain('All specs passed!'); | ||
} | ||
expect(await killPort(4200)).toBeTruthy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port being killed (4200) doesn't match the port configured for the Next.js app (3000). Consider updating line 36 to expect(await killPort(3000)).toBeTruthy();
to ensure the correct port is terminated after the test completes.
expect(await killPort(4200)).toBeTruthy(); | |
expect(await killPort(3000)).toBeTruthy(); |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
- e2e-ci**module-federation/misc-rspack-interoperability** | ||
- e2e-ci**module-federation/dynamic-federation.webpack** | ||
- e2e-ci**docker** | ||
- e2e-ci**module-federation/misc-rspack-interoperability** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is a duplicate of line 42. The same target 'e2e-cimodule-federation/misc-rspack-interoperability' is listed twice, which could cause confusion or unexpected behavior in the workflow execution.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
31c33b2
to
7d71c4e
Compare
7d71c4e
to
e40e2c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The failure is classified as 'environment_state' due to the following factors:
Environmental Indicators Present:
- Network error: HTTP 404 Not Found from npm registry
- External service failure: Local npm registry at localhost:4873 is missing the required package
- Package manager failure: pnpm unable to fetch yargs-parser dependency
No Correlation with Code Changes:
The PR modifies .nx/workflows/dynamic-changesets.yaml
to consolidate test targets from an explicit list to a wildcard pattern (e2e-ci**
) and changes the cache bust value in nx.json
from 6 to 12. These configuration changes control test execution parallelism and caching behavior but do not affect package resolution, dependency availability, or npm registry contents.
Failure Occurs During Test Setup:
The error happens during the workspace creation phase (pnpm dlx create-nx-workspace@22.0.0
) before any test logic executes. The workspace setup process requires fetching yargs-parser
as a transitive dependency of create-nx-workspace
, but the local test registry does not have this package available.
Potentially Pre-existing Issue:
The similar task failures reference indicates this test also fails on the master branch, suggesting the environmental issue exists independently of this PR's changes.
No Direct Link to Changed Code:
The error does not reference any modified files, functions, or configuration that was changed in this PR. The workflow configuration changes would not cause a package to disappear from or fail to be available in the npm registry.
The local npm registry environment needs to be fixed to ensure all required packages, including yargs-parser, are properly available for test workspace creation.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
…nd affected-graph
Split the following test suites into smaller, more focused tests:
Fixes CLOUD-3756
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #