Skip to content

Conversation

leosvelperez
Copy link
Member

Current Behavior

Pnpm Catalogs is not supported.

Expected Behavior

Pnpm Catalogs should be supported.

Related Issue(s)

Fixes #30035
Fixes #29772

@leosvelperez leosvelperez self-assigned this Oct 6, 2025
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Oct 15, 2025 5:20pm

Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 41fddb4
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/68efd1dc9b8f03000805ad34
😎 Deploy Preview https://deploy-preview-32978--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

nx-cloud bot commented Oct 6, 2025

View your CI Pipeline Execution ↗ for commit 41fddb4

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 3m 55s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 50s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-15 19:08:41 UTC

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Failed to publish a PR release of this pull request, triggered by @leosvelperez.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/18287018769

Copy link
Contributor

github-actions bot commented Oct 7, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-32978-2f0e271 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32978-2f0e271
Release details 📑
Published version 0.0.0-pr-32978-2f0e271
Triggered by @leosvelperez
Branch feat/support-pnpm-catalogs
Commit 2f0e271
Workflow run 18308363858

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Failed to publish a PR release of this pull request, triggered by @leosvelperez.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/18336031988

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-32978-f3ca7f3 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32978-f3ca7f3
Release details 📑
Published version 0.0.0-pr-32978-f3ca7f3
Triggered by @leosvelperez
Branch feat/support-pnpm-catalogs
Commit f3ca7f3
Workflow run 18337442796

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link
Contributor

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-32978-3904cbf my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32978-3904cbf
Release details 📑
Published version 0.0.0-pr-32978-3904cbf
Triggered by @leosvelperez
Branch feat/support-pnpm-catalogs
Commit 3904cbf
Workflow run 18466805131

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

nx-cloud[bot]

This comment was marked as outdated.

@leosvelperez leosvelperez force-pushed the feat/support-pnpm-catalogs branch 2 times, most recently from 9565134 to 0c22436 Compare October 14, 2025 09:04
nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-32978-0c22436 my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32978-0c22436
Release details 📑
Published version 0.0.0-pr-32978-0c22436
Triggered by @leosvelperez
Branch feat/support-pnpm-catalogs
Commit 0c22436
Workflow run 18495100148

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

The test failure in e2e-cypress:e2e-ci--src/cypress-legacy.test.ts is classified as 'flaky_task' because it is unrelated to the PR's code changes for pnpm catalog support.

The PR introduces functionality for handling pnpm catalogs in dependency management, including:

  • Support for catalogs.default definition and catalog:default reference
  • Handling catalog references in dependency-checks eslint rule
  • Handling catalog references in version action
  • Fixes to semver utility

However, the test failure is about port cleanup after running a Cypress e2e test. The error occurs when attempting to kill processes on port 4200:

"expect(await killPort(4200)).toBeTruthy()"
Received: false

The underlying issue is that the lsof command found no processes listening on port 4200, causing xargs kill -9 to fail with exit code 123 because it received no process IDs to kill. This indicates the port was likely already closed when the cleanup function ran.

This failure is characteristic of flaky e2e tests where:

  1. Process shutdown timing varies between runs
  2. Port cleanup operations may race with natural process termination
  3. The failure is in test infrastructure (port cleanup), not the application code being tested
  4. The error has no logical connection to pnpm catalog functionality

The test would likely pass on a retry if the timing of process shutdown differs, making this a classic flaky test scenario rather than an issue introduced by the pnpm catalog changes.

A code change would likely not resolve this issue, so no action was taken.

Nx CloudView in Nx Cloud ↗


🎓 To learn more about Self Healing CI, please visit nx.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PNPM Catalogs are not supported Generators don't work when using pnpm catalogs

3 participants