-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(core): add support for pnpm catalogs #32978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
View your CI Pipeline Execution ↗ for commit 41fddb4
☁️ Nx Cloud last updated this comment at |
Failed to publish a PR release of this pull request, triggered by @leosvelperez. |
4e07c34
to
2f0e271
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32978-2f0e271 my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-32978-2f0e271
To request a new release for this pull request, mention someone from the Nx team or the |
2f0e271
to
db876a4
Compare
Failed to publish a PR release of this pull request, triggered by @leosvelperez. |
db876a4
to
c9435a8
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32978-f3ca7f3 my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-32978-f3ca7f3
To request a new release for this pull request, mention someone from the Nx team or the |
f3ca7f3
to
3904cbf
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32978-3904cbf my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-32978-3904cbf
To request a new release for this pull request, mention someone from the Nx team or the |
9565134
to
0c22436
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32978-0c22436 my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-32978-0c22436
To request a new release for this pull request, mention someone from the Nx team or the |
packages/angular/src/generators/ngrx-root-store/lib/normalize-options.ts
Outdated
Show resolved
Hide resolved
0c22436
to
ba1e81f
Compare
ba1e81f
to
41fddb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The test failure in e2e-cypress:e2e-ci--src/cypress-legacy.test.ts is classified as 'flaky_task' because it is unrelated to the PR's code changes for pnpm catalog support.
The PR introduces functionality for handling pnpm catalogs in dependency management, including:
- Support for catalogs.default definition and catalog:default reference
- Handling catalog references in dependency-checks eslint rule
- Handling catalog references in version action
- Fixes to semver utility
However, the test failure is about port cleanup after running a Cypress e2e test. The error occurs when attempting to kill processes on port 4200:
"expect(await killPort(4200)).toBeTruthy()"
Received: false
The underlying issue is that the lsof command found no processes listening on port 4200, causing xargs kill -9 to fail with exit code 123 because it received no process IDs to kill. This indicates the port was likely already closed when the cleanup function ran.
This failure is characteristic of flaky e2e tests where:
- Process shutdown timing varies between runs
- Port cleanup operations may race with natural process termination
- The failure is in test infrastructure (port cleanup), not the application code being tested
- The error has no logical connection to pnpm catalog functionality
The test would likely pass on a retry if the timing of process shutdown differs, making this a classic flaky test scenario rather than an issue introduced by the pnpm catalog changes.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
Current Behavior
Pnpm Catalogs is not supported.
Expected Behavior
Pnpm Catalogs should be supported.
Related Issue(s)
Fixes #30035
Fixes #29772