Skip to content

feat(core): log out-of-sync details returned by sync generators when running nx sync:check #32072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

leosvelperez
Copy link
Member

Current Behavior

The @nx/js:typescript-sync generator does not provide details about the out-of-sync files. It only returns a generic message.

image

Expected Behavior

The nx sync:check command should display additional details about the out-of-sync files if provided by the sync generators. The @nx/js:typescript-sync generator should provide details about the out-of-sync files.

image

Note: the nx sync command will still only display the generic message to avoid cluttering the logs and the details can be seen in the changes made to files.

@leosvelperez leosvelperez self-assigned this Jul 24, 2025
@leosvelperez leosvelperez requested review from a team as code owners July 24, 2025 10:47
@leosvelperez leosvelperez requested a review from AgentEnder July 24, 2025 10:47
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 25, 2025 8:45am

Copy link
Contributor

nx-cloud bot commented Jul 24, 2025

View your CI Pipeline Execution ↗ for commit c0752c0

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 4m 51s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 24s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-25 12:20:23 UTC

@leosvelperez leosvelperez force-pushed the js/ts-sync-verbose-return-details branch from 9032bff to c0752c0 Compare July 25, 2025 08:33
@leosvelperez leosvelperez changed the title feat(js): log out-of-sync details returned by sync generators when running nx sync:check feat(core): log out-of-sync details returned by sync generators when running nx sync:check Jul 25, 2025
@leosvelperez leosvelperez enabled auto-merge (squash) July 25, 2025 08:34
@leosvelperez leosvelperez merged commit 1b1de90 into master Jul 25, 2025
7 of 11 checks passed
@leosvelperez leosvelperez deleted the js/ts-sync-verbose-return-details branch July 25, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants