feat(js): ignore scoped export conditions #32063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 6a70c29
☁️ Nx Cloud last updated this comment at |
aidant
force-pushed
the
feat-ignore-scoped-export-conditions
branch
from
14da10d to
6a70c29
Compare
aidant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an emerging pattern of using scoped custom export conditions for pointing to source. See:
Current Behavior
When including an export condition that points to the source code the typescript plugin does not add a build target. However, if this export condition is named
developmentthe build target is added.Expected Behavior
Scoped export conditions pointing at source should not remove the build target.
Related Issue(s)