Skip to content

fix(core): improve tui minimal view display and prevent flashing scrollbar #32045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

leosvelperez
Copy link
Member

Current Behavior

  • When the minimal view in the TUI is shown, some borders are initially shown for a fraction of a second.
  • When rendering terminal panes, the scrollbar can be wrongly shown for a fraction of a second when the PTY dimensions are stale. This looks like the scrollbar flashes.

Expected Behavior

  • When the minimal view in the TUI is shown, no borders should ever be shown.
  • The scrollbar should only be shown when rendering terminal panes when needed.

@leosvelperez leosvelperez self-assigned this Jul 23, 2025
@leosvelperez leosvelperez requested review from a team as code owners July 23, 2025 11:09
Copy link
Contributor

nx-cloud bot commented Jul 23, 2025

View your CI Pipeline Execution ↗ for commit 127c279

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 9m 57s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 2m 1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-24 14:37:09 UTC

Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 24, 2025 3:10pm

@leosvelperez leosvelperez force-pushed the fix/tui-minimal-view-flash branch from 8e89053 to 127c279 Compare July 24, 2025 14:22
@leosvelperez leosvelperez merged commit d0cbfec into master Jul 24, 2025
4 checks passed
@leosvelperez leosvelperez deleted the fix/tui-minimal-view-flash branch July 24, 2025 15:14
jaysoo pushed a commit that referenced this pull request Jul 25, 2025
…llbar (#32045)

## Current Behavior

- When the minimal view in the TUI is shown, some borders are initially
shown for a fraction of a second.
- When rendering terminal panes, the scrollbar can be wrongly shown for
a fraction of a second when the PTY dimensions are stale. This looks
like the scrollbar flashes.

## Expected Behavior

- When the minimal view in the TUI is shown, no borders should ever be
shown.
- The scrollbar should only be shown when rendering terminal panes when
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants