Skip to content

fix(core): move bin and scripts fields to nxConfig in package.json #32021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jul 22, 2025

Currently

When we run pnpm i install the Nx repo we get logs and warnings due to the local nx package running it's post-install script

 WARN  Failed to create bin at /../nx/node_modules/.bin/nx. ENOENT: no such file or directory, open '../packages/nx/bin/nx.js'
 WARN  Failed to create bin at ../e2e/plugin/node_modules/.bin/nx-cloud. ENOENT: no such file or directory, open '../packages/nx/bin/nx-cloud.js'
 WARN  Failed to create bin at /../e2e/angular/node_modules/.bin/nx. ENOENT: no such file or directory, open '/../packages/nx/bin/nx.js'

Expected

We should restrict local packages post-install from being run in this context.

Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 24, 2025 9:38pm

Copy link
Contributor

nx-cloud bot commented Jul 22, 2025

View your CI Pipeline Execution ↗ for commit 205e22e

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 1h 9m 31s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 37s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 5m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-24 22:45:33 UTC

@ndcunningham ndcunningham force-pushed the fix/pnpm-install-post-scripts-install branch from efa3f90 to 205e22e Compare July 24, 2025 21:24
@ndcunningham ndcunningham changed the title fix(core): move bin and scripts fields to publishConfig in package.json fix(core): move bin and scripts fields to nxConfig in package.json Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant