fix(core): derive graph node type correctly when projectType is not set
#32018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 2ad334a
☁️ Nx Cloud last updated this comment at |
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32018-c6ab05e my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32018-c6ab05e
To request a new release for this pull request, mention someone from the Nx team or the |
leosvelperez
force-pushed
the
fix/issue-31983-wrong-project-type
branch
from
c6ab05e to
d3c2920
Compare
AgentEnder
approved these changes
Jul 22, 2025
leosvelperez
force-pushed
the
fix/issue-31983-wrong-project-type
branch
from
d3c2920 to
1ec2cae
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32018-1ec2cae my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32018-1ec2cae
To request a new release for this pull request, mention someone from the Nx team or the |
leosvelperez
force-pushed
the
fix/issue-31983-wrong-project-type
branch
from
1ec2cae to
f7d8443
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
leosvelperez
force-pushed
the
fix/issue-31983-wrong-project-type
branch
from
f7d8443 to
e3f6314
Compare
leosvelperez
force-pushed
the
fix/issue-31983-wrong-project-type
branch
from
e3f6314 to
b5b74c7
Compare
…erator and update release e2e tests
leosvelperez
force-pushed
the
fix/issue-31983-wrong-project-type
branch
from
b5b74c7 to
2ad334a
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@0.0.0-pr-32018-2ad334a my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-32018-2ad334a
To request a new release for this pull request, mention someone from the Nx team or the |
jaysoo
approved these changes
Jul 25, 2025
jaysoo
pushed a commit
that referenced
this pull request
Jul 25, 2025
… set (#32018) ## Current Behavior When building the project graph nodes, the node `type` is always inferred as `lib` when `projectType` is not set. ## Expected Behavior When building the project graph nodes, the node `type` should be derived correctly using the same logic used by generators when `projectType` is not set. ## Related Issue(s) Fixes #31983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When building the project graph nodes, the node
typeis always inferred aslibwhenprojectTypeis not set.Expected Behavior
When building the project graph nodes, the node
typeshould be derived correctly using the same logic used by generators whenprojectTypeis not set.Related Issue(s)
Fixes #31983