Skip to content

fix(core): run task hasher in serial instead of parallel #32003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(core): run task hasher in serial instead of parallel #32003

wants to merge 1 commit into from

Conversation

AgentEnder
Copy link
Member

Current Behavior

The task hasher currently uses parallel processing via .par_bridge() to hash task instructions concurrently.

Expected Behavior

This PR changes the task hasher to run serially by removing the .par_bridge() call, making the processing sequential instead of parallel.

Related Issue(s)

This change is being made to test performance impact and debug potential thread-related issues with the task hasher.

Test Plan

  • Build the native module with nx build nx
  • Run existing tests to ensure functionality is preserved
  • Performance testing can be done to compare serial vs parallel hashing times

🤖 Generated with Claude Code

@AgentEnder AgentEnder requested review from a team as code owners July 21, 2025 19:00
@vercel Vercel
Copy link

vercel bot commented Jul 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 21, 2025 8:42pm

@nx-cloud Nx Cloud
Copy link
Contributor

nx-cloud bot commented Jul 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 86be0dc

Command Status Duration Result
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 33s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded <1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 2m 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-21 20:37:19 UTC

@github-actions GitHub Actions
Copy link

Failed to publish a PR release of this pull request, triggered by @AgentEnder.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/16425706906

@AgentEnder
fix(core): run task hasher in serial instead of parallel
86be0dc 
Remove parallel processing from task hasher to test performance impact
and debug potential thread-related issues.

- Changed .par_bridge() to serial .try_for_each()
- This makes hash instruction processing sequential
@github-actions GitHub Actions
Copy link

Failed to publish a PR release of this pull request, triggered by @xiongemi.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/16426843205

@github-actions GitHub Actions
Copy link

Failed to publish a PR release of this pull request, triggered by @AgentEnder.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/16425706906

@AgentEnder AgentEnder force-pushed the fix/serial-task-hasher branch from bf4b462 to 86be0dc Compare July 21, 2025 20:29
@github-actions GitHub Actions
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-32003-86be0dc my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-32003-86be0dc
Release details 📑
Published version 0.0.0-pr-32003-86be0dc
Triggered by @AgentEnder
Branch fix/serial-task-hasher
Commit 86be0dc
Workflow run 16425706906

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@AgentEnder AgentEnder marked this pull request as draft July 28, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leosvelperez leosvelperez Awaiting requested review from leosvelperez leosvelperez is a code owner automatically assigned from nrwl/nx-core-reviewers

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner automatically assigned from nrwl/nx-native-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AgentEnder