fix(js): resolve relative imports correctly in nested projects #31978
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving "./" imports from a nested project, the target project locator was incorrectly resolving to the parent project instead of the current project. This was caused by trailing slashes in the resolved module path not matching the project root mappings. The fix removes trailing slashes from normalized resolved module paths to ensure proper project matching.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 5a47df8
☁️ Nx Cloud last updated this comment at |
barbados-clemens
approved these changes
Jul 18, 2025
AgentEnder
approved these changes
Jul 24, 2025
jaysoo
pushed a commit
that referenced
this pull request
Jul 25, 2025
## Current Behavior When resolving "./" imports from a nested project, the target project locator incorrectly resolves to the parent project instead of the current project. For example, given: - `parent-project` at `libs/parent-path` - `child-project` at `libs/parent-path/child-path` (nested 1 level under parent) When importing "./" from `libs/parent-path/child-path/module.ts`, it incorrectly resolves to `parent-project` instead of `child-project`. ## Expected Behavior "./" imports from within a nested project should resolve to that project, not its parent. ## Related Issue(s) Fixes #31980
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When resolving "./" imports from a nested project, the target project locator incorrectly resolves to the parent project instead of the current project.
For example, given:
parent-projectatlibs/parent-pathchild-projectatlibs/parent-path/child-path(nested 1 level under parent)When importing "./" from
libs/parent-path/child-path/module.ts, it incorrectly resolves toparent-projectinstead ofchild-project.Expected Behavior
"./" imports from within a nested project should resolve to that project, not its parent.
Related Issue(s)
Fixes #31980