Skip to content

fix(core): add registerExitHandler utility #31132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

AgentEnder
Copy link
Member

Current Behavior

We register a bunch of signal listeners everywhere, and depending on the order they are registered not all are running. Also, we have to make sure to actually shut the process down...

Expected Behavior

Signal listeners are registered through a common util, which handles process shutdown.

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 8, 2025 5:33pm

Copy link

nx-cloud bot commented May 8, 2025

View your CI Pipeline Execution ↗ for commit 4fc0a47.

Command Status Duration Result
nx-cloud record -- nx-cloud conformance:check ❌ Failed 3s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ❌ Failed 6m 31s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-08 17:43:58 UTC

@AgentEnder AgentEnder force-pushed the exit-handler branch 2 times, most recently from 108a075 to 812ff08 Compare May 8, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant