fix(launch-templates): add patches directories to cache key in linux template #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
force-pushed
the
cu/use-patch-paths-cache
branch
from
1711985 to
66c6ddc
Compare
|
View your CI Pipeline Execution ↗ for commit 1210da6
☁️ Nx Cloud last updated this comment at |
barbados-clemens
requested review from
Copilot and
rarmatei
and removed request for
rarmatei
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Node Modules Cache key in the Linux launch template to include patches directories, ensuring cache invalidation when patches change.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pmariglia
approved these changes
Aug 22, 2025
|
need to come back and test this changes since it's been a spell |
…template - Include patches directories (patches/**, .yarn/patches/**, pnpm-patches/**) in the Node Modules Cache key - Ensures cache is properly invalidated when patch files change - Prevents stale patches from being used in CI/CD pipelines Related to nrwl/nx#DOC-152
barbados-clemens
force-pushed
the
cu/use-patch-paths-cache
branch
from
66c6ddc to
1210da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patches=> patch-package, pnpm.yarn/patches=> yarndocs change: nrwl/nx#32454
Related to DOC-152