Skip to content

fix(install-node): always install latest corepack version #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

fix(install-node): always install latest corepack version #93

merged 2 commits into from
May 3, 2025

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented May 3, 2025 •
edited
Loading

  • fix(install-node): make sure to always install latest corepack
  • fix(install-node): make sure to match default pnpm version from base image
image

@barbados-clemens
fix(install-node): make sure to always install latest corepack
c5e491f 
sometimes node versions of corepack comes with outdate key signatures.
this changes makes sure to always install the latest version of corepack
after updating node
@barbados-clemens
fix(install-node): make sure to match default pnpm version from base …
5f92727 
…image

base image use pnpm v9, so default install pnpm v9 when installing new
node versions as well
@barbados-clemens barbados-clemens changed the title fix latest corepack fix(install-node): always install latest corepack version May 3, 2025
@barbados-clemens barbados-clemens self-assigned this May 3, 2025
@barbados-clemens barbados-clemens marked this pull request as ready for review May 3, 2025 23:07
@barbados-clemens
Copy link
Contributor Author

working here: https://staging.nx.app/cipes/6816a523c4825a42f5d8c08c?step=fde16504-3196-4cea-a25b-c9da2c6e1cba&runGroup=&launchTemplate=linux-medium-js#step-list-pane

@barbados-clemens barbados-clemens merged commit fed180c into main May 3, 2025
1 check passed
@barbados-clemens barbados-clemens deleted the fix-latest-corepack branch May 3, 2025 23:24
github-actions bot pushed a commit that referenced this pull request May 3, 2025
@barbados-clemens @github-actions
fix(install-node): always install latest corepack version (#93)
029630c 
* fix(install-node): make sure to always install latest corepack

sometimes node versions of corepack comes with outdate key signatures.
this changes makes sure to always install the latest version of corepack
after updating node

* fix(install-node): make sure to match default pnpm version from base image

base image use pnpm v9, so default install pnpm v9 when installing new
node versions as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nartc nartc nartc approved these changes

Assignees

@barbados-clemens barbados-clemens

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barbados-clemens @nartc