Skip to content

bluetooth: services: reduce size of cs_de_iq_tones_t and add more docs #22889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bluetooth: services: reduce size of cs_de_iq_tones_t and add more docs #22889

wants to merge 1 commit into from

Conversation

olivier-le-sage
Copy link
Contributor

@olivier-le-sage olivier-le-sage commented Jun 19, 2025 •
edited
Loading

Saves up to 5 x 4 x 4 APs x sizeof(float)=320 bytes of RAM.

Also added clarification about struct contents since some users are
trying to use these values directly.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jun 19, 2025
@olivier-le-sage
bluetooth: services: reduce size of cs_de_iq_tones_t and add more docs
9269eda 
Saves up to 5 x 4 x 4 APs x sizeof(float)=320 bytes of RAM.

Also added clarification about struct contents since some users are
trying to use these values directly.

Signed-off-by: Olivier Lesage <olivier.lesage@nordicsemi.no>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 19, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 9269edaaa1a9a84c8e3a6f44742000e6cd038d36

more details

sdk-nrf:

PR head: 9269edaaa1a9a84c8e3a6f44742000e6cd038d36
merge base: f6e2d521535773a20a94f40ca5fc4c6249a3642b
target head (main): acb785bf0444c48415fe611abaaa286887559314
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
include
│  ├── bluetooth
│  │  │ cs_de.h

Outputs:

Toolchain

Version: 4aa3467a6d
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4aa3467a6d_776d264d2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 9
  • ✅ Integration tests
    • ✅ desktop52_verification
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-sdk-find-my
    • ⚠️ test_ble_nrf_config
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@olivier-le-sage olivier-le-sage force-pushed the add-docs-optimize-memory branch from b469c7a to 9269eda Compare June 19, 2025 08:39
@olivier-le-sage
Copy link
Contributor Author

note to self: waiting for BLE to be removed from quarantine before re-running CI and possibly merging

@github-actions GitHub Actions
Copy link

You can find the documentation preview for this PR here.

@olivier-le-sage olivier-le-sage marked this pull request as ready for review June 19, 2025 13:47
@olivier-le-sage olivier-le-sage requested a review from a team as a code owner June 19, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivier-le-sage @NordicBuilder