-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Applications: nrf5340_audio: Changed buf counts #22887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Applications: nrf5340_audio: Changed buf counts #22887
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 5a0a1969583e12ec189e7e20371a9178236715fd more detailssdk-nrf:
Github labels
List of changed files detected by CI (8)
Outputs:ToolchainVersion: 4aa3467a6d Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
e25a8a5
to
d71f9de
Compare
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: |
d71f9de
to
602b16a
Compare
OCT-3399 Changed buffer counts to reflect controller defaults Signed-off-by: Kristoffer Skøien <kristoffer.skoien@nordicsemi.no>
602b16a
to
5a0a196
Compare
Bluetooth nRF_Auraconfig sample | ||
------------------------------- | ||
|
||
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move under Bluetooth samples, as this sample does not have its own section under Samples.
After moving, change entry to following:
Bluetooth nRF_Auraconfig sample | |
------------------------------- | |
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases. | |
* :ref:`nrf_auraconfig` sample: | |
* Updated the buffer count (:kconfig:option:`CONFIG_BT_ISO_TX_BUF_COUNT`) to be in-line with SoftDevice Controller (SDC) defaults. | |
This can be changed and optimized for specific use cases. |
(edited with Richa's suggestion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."
@@ -227,6 +227,7 @@ nRF5340 Audio | |||
The :ref:`net_buf_interface` will also contain the metadata about the audio stream in the ``user_data`` section of the API. | |||
This change was done to transition to standard Zephyr APIs, as well as to have a structured way to pass N-channel audio between modules. | |||
* The optional buildprog tool to use `nRF Util`_ instead of nrfjprog that has been deprecated. | |||
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases. | |
* The buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. | |
This can be changed and optimized for specific use cases. |
(edited with Richa's suggestion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."
Bluetooth nRF_Auraconfig sample | ||
------------------------------- | ||
|
||
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."
@@ -227,6 +227,7 @@ nRF5340 Audio | |||
The :ref:`net_buf_interface` will also contain the metadata about the audio stream in the ``user_data`` section of the API. | |||
This change was done to transition to standard Zephyr APIs, as well as to have a structured way to pass N-channel audio between modules. | |||
* The optional buildprog tool to use `nRF Util`_ instead of nrfjprog that has been deprecated. | |||
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."
No description provided.