Skip to content

Applications: nrf5340_audio: Changed buf counts #22887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koffes
Copy link
Contributor

@koffes koffes commented Jun 19, 2025

No description provided.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jun 19, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jun 19, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 5a0a1969583e12ec189e7e20371a9178236715fd

more details

sdk-nrf:

PR head: 5a0a1969583e12ec189e7e20371a9178236715fd
merge base: 3b785730cec207fb725dbfabaa839b4e440d4477
target head (main): acb785bf0444c48415fe611abaaa286887559314
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
applications
│  ├── nrf5340_audio
│  │  ├── broadcast_source
│  │  │  │ overlay-broadcast_source.conf
│  │  ├── prj.conf
│  │  ├── prj_fota.conf
│  │  ├── prj_release.conf
│  │  ├── src
│  │  │  ├── bluetooth
│  │  │  │  ├── bt_stream
│  │  │  │  │  ├── unicast
│  │  │  │  │  │  │ Kconfig.defaults
│  │  ├── unicast_client
│  │  │  │ overlay-unicast_client.conf
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── nrf_auraconfig
│  │  │  │ prj.conf

Outputs:

Toolchain

Version: 4aa3467a6d
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4aa3467a6d_776d264d2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 9
  • ✅ Integration tests
    • ✅ test-sdk-audio
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@koffes koffes force-pushed the OCT-3399-buffer-change-upmerge-june-2025 branch 2 times, most recently from e25a8a5 to d71f9de Compare June 19, 2025 07:43
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-22887/nrf/releases_and_maturity/releases/release-notes-changelog.html

@koffes koffes force-pushed the OCT-3399-buffer-change-upmerge-june-2025 branch from d71f9de to 602b16a Compare June 19, 2025 08:40
OCT-3399
Changed buffer counts to reflect controller defaults

Signed-off-by: Kristoffer Skøien <kristoffer.skoien@nordicsemi.no>
@koffes koffes force-pushed the OCT-3399-buffer-change-upmerge-june-2025 branch from 602b16a to 5a0a196 Compare June 19, 2025 08:48
@koffes koffes marked this pull request as ready for review June 19, 2025 08:48
@koffes koffes requested review from a team as code owners June 19, 2025 08:48
@koffes koffes changed the title Oct 3399 buffer change upmerge june 2025 Applications: nrf5340_audio: Changed buf counts Jun 19, 2025
Comment on lines +344 to +347
Bluetooth nRF_Auraconfig sample
-------------------------------

* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases.
Copy link
Contributor

@greg-fer greg-fer Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move under Bluetooth samples, as this sample does not have its own section under Samples.
After moving, change entry to following:

Suggested change
Bluetooth nRF_Auraconfig sample
-------------------------------
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases.
* :ref:`nrf_auraconfig` sample:
* Updated the buffer count (:kconfig:option:`CONFIG_BT_ISO_TX_BUF_COUNT`) to be in-line with SoftDevice Controller (SDC) defaults.
This can be changed and optimized for specific use cases.

(edited with Richa's suggestion)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."

@@ -227,6 +227,7 @@ nRF5340 Audio
The :ref:`net_buf_interface` will also contain the metadata about the audio stream in the ``user_data`` section of the API.
This change was done to transition to standard Zephyr APIs, as well as to have a structured way to pass N-channel audio between modules.
* The optional buildprog tool to use `nRF Util`_ instead of nrfjprog that has been deprecated.
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases.
Copy link
Contributor

@greg-fer greg-fer Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases.
* The buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults.
This can be changed and optimized for specific use cases.

(edited with Richa's suggestion)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."

Comment on lines +344 to +347
Bluetooth nRF_Auraconfig sample
-------------------------------

* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."

@@ -227,6 +227,7 @@ nRF5340 Audio
The :ref:`net_buf_interface` will also contain the metadata about the audio stream in the ``user_data`` section of the API.
This change was done to transition to standard Zephyr APIs, as well as to have a structured way to pass N-channel audio between modules.
* The optional buildprog tool to use `nRF Util`_ instead of nrfjprog that has been deprecated.
* Buffer count (CONFIG_BT_ISO_TX_BUF_COUNT and CONFIG_BT_BUF_ACL_TX_COUNT) to be in-line with SoftDevice Controller (SDC) defaults. This can be changed and optimized for specific use-cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Greg's suggestion, move the second sentence to the new line:
"This can be changed and optimized for specific use cases."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants