Skip to content

Conversation

SamuelLarkin
Copy link
Contributor

No description provided.

@SamuelLarkin SamuelLarkin force-pushed the dev.sl/workflow branch 2 times, most recently from 046e38f to 31c734e Compare January 29, 2025 13:49
max-parallel: 5
matrix:
python: [3.7, 3.8]
python: ["3.8", "3.9", "3.10", "3.11", "3.12"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why quoting?
As for the confusing error message, it is a feature of YAML parsing. When you specify input like

version: 3.10

3.10 is parsed as a number and it is trimmed to 3.1 that looks like expected behavior for numbers.
You should specify input with quotes to treat it as string.

version: '3.10'

actions/setup-python#160 (comment)
actions/runner#1989

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got bit by this many times, trying to install Python 3.1. It's very annoying.

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

max-parallel: 5
matrix:
python: [3.7, 3.8]
python: ["3.8", "3.9", "3.10", "3.11", "3.12"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got bit by this many times, trying to install Python 3.1. It's very annoying.

Comment on lines +14 to +16
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python }}
uses: actions/setup-python@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the action versions. We'll probably need to do the same in TextProcessing.

@SamuelLarkin SamuelLarkin merged commit 29e03b2 into main Jan 29, 2025
5 checks passed
@joanise joanise deleted the dev.sl/workflow branch January 29, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants