Skip to content

fix(arborist): maintain protocol of replaced registryURL #8330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(arborist): maintain protocol of replaced registryURL #8330

wants to merge 2 commits into from

Conversation

alexsch01
Copy link
Contributor

fixes #8324

@alexsch01 alexsch01 requested a review from a team as a code owner May 27, 2025 10:54
@alexsch01 alexsch01 mentioned this pull request May 27, 2025
Closed
2 tasks
@wraithgar
Copy link
Member

We'll definitely need a test for this

@alexsch01
Copy link
Contributor Author

We'll definitely need a test for this

I modified the existing test

@wraithgar
Copy link
Member

The code change looks good. However, I am hesitant to support http:// for anything except localhost. I am also hesitant to try to add what is almost certainly a larger task than it seems in trying to determine if the hostname is some analog for localhost.

I'd welcome other folks' thoughts on this.

@alexsch01
Copy link
Contributor Author

Not a big deal to me (I only found this when debugging another issue report)

@alexsch01 alexsch01 closed this May 28, 2025
@alexsch01 alexsch01 deleted the maintain-protocol branch May 28, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] fix from https://github.com/npm/cli/pull/8222 doesn't maintain scheme of replaced repo URL
2 participants
@alexsch01 @wraithgar