feat(ws): add context logic to enterprise WS worker fixes NV-6821 #9385
+132
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
github-actions
bot
changed the title
ChmaraX
commented
Oct 22, 2025
Comment on lines
323
to
363
| private formatContextDisplay(contextKeys?: string[]): string { | ||
| if (contextKeys === undefined) { | ||
| return 'FF disabled'; | ||
| } | ||
|
|
||
| if (contextKeys.length === 0) { | ||
| return 'no context'; | ||
| } | ||
|
|
||
| return contextKeys.join(', '); | ||
| } | ||
|
|
||
| /** | ||
| * Check if feature flag is OFF (contextKeys is undefined) | ||
| */ | ||
| private isFeatureFlagOff(contextKeys?: string[]): boolean { | ||
| return contextKeys === undefined; | ||
| } | ||
|
|
||
| /** | ||
| * Broadcast message to all user connections (FF OFF behavior) | ||
| */ | ||
| private async broadcastToAllSockets( | ||
| userId: string, | ||
| event: string, | ||
| message: string, | ||
| sockets: WebSocket[] | ||
| ): Promise<void> { | ||
| console.log(`Sending event ${event} to all ${sockets.length} socket(s) (FF disabled)`); | ||
|
|
||
| const sendPromises = sockets.map(async (ws) => { | ||
| try { | ||
| ws.send(message); | ||
| } catch (error) { | ||
| console.error(`Failed to send message to user ${userId}:`, error); | ||
| throw error; | ||
| } | ||
| }); | ||
|
|
||
| await Promise.allSettled(sendPromises); | ||
| } |
There was a problem hiding this comment.
This part can be deleted when we remove the feature flag
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
WalkthroughThis pull request implements context-aware message routing for WebSocket connections. ContextKeys are extracted from JWT payloads via middleware, propagated through handlers during WebSocket handshake, and stored in socket attachments. Messages can now be routed either to all connected sockets or selectively to sockets with matching context keys, controlled by feature flags. Changes
Sequence DiagramsequenceDiagram
participant Client
participant AuthMW as Auth Middleware
participant Handler as WebSocket Handler
participant Handshake as WS Handshake
participant Room as WebSocket Room (DO)
participant Sockets as Connected Sockets
Client->>AuthMW: Request with JWT
AuthMW->>AuthMW: Extract contextKeys from JWT
AuthMW->>Handler: Forward context with contextKeys
Client->>Handler: WebSocket upgrade
Handler->>Handler: Get contextKeys from context
Handler->>Handshake: includeHeaders: X-Context-Keys
Handshake->>Room: Establish connection
Room->>Room: Extract X-Context-Keys header
Room->>Room: Store contextKeys in attachment
Client->>Handler: Send message
Handler->>Handler: Extract contextKeys from body
Handler->>Room: sendToUser(userId, event, data, contextKeys)
alt contextKeys is undefined (Feature OFF)
Room->>Sockets: Broadcast to all sockets
else contextKeys is defined (Feature ON)
Room->>Room: Match contextKeys on each socket
Room->>Sockets: Deliver only to matching contexts
end
Sockets-->>Client: Message received
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes The changes span multiple layers (middleware, handler, core logic, types) with cohesive context propagation flow. While introducing new conditional routing logic and helpers, the patterns are consistent across files. Public API signature changes require validation but the scope is focused on a single feature. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
scopsy
approved these changes
Oct 22, 2025
enterprise/workers/socket/src/durable-objects/websocket-room.ts
Outdated
Show resolved
Hide resolved
ChmaraX
deleted the
nv-6821-updating-cloudflare-sockets-with-new-context-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Fixes NV-6817
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer
Summary by CodeRabbit