Skip to content

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Oct 20, 2025

What changed? Why was the change needed?

Previously, the POST /v1/integrations, PUT /v1/integrations/:integrationId, and POST /v1/integrations/:integrationId/set-primary API endpoints returned encrypted integration credentials. This was inconsistent with the GET /v1/integrations endpoint, which returns unencrypted credentials.

This change modifies these endpoints to return unencrypted credentials, aligning their behavior with the GET endpoint. This resolves the inconsistency and addresses the need for users (e.g., Terraform providers) to compare configured values with actual Novu values, as detailed in NV-6770.

Screenshots

N/A

Expand for optional sections

Related enterprise PR

N/A

Special notes for your reviewer

Credential decryption and return are conditional on the user having INTEGRATION_WRITE permissions, ensuring proper Role-Based Access Control (RBAC).


Linear Issue: NV-6770

Open in Cursor Open in Web

This change prevents users from seeing sensitive integration credentials if they do not have the necessary permissions. The credentials are only returned if the user has access.

Co-authored-by: dima <dima@novu.co>
@cursor
Copy link
Contributor

cursor bot commented Oct 20, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@linear
Copy link

linear bot commented Oct 20, 2025

@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 96a9db8
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/68f7cedd0394140008be4f79

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(api-service): post integrations api credential encryption

Requirements:

  1. Follow the Conventional Commits specification
  2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

@scopsy scopsy changed the title Fix post integrations api credential encryption fix(api-service): post integrations api credential encryption Oct 21, 2025
…ryption-9766' of https://github.com/novuhq/novu into cursor/NV-6770-fix-post-integrations-api-credential-encryption-9766
@scopsy scopsy marked this pull request as ready for review October 21, 2025 18:21
@scopsy scopsy merged commit 1645f7d into next Oct 21, 2025
33 of 35 checks passed
@scopsy scopsy deleted the cursor/NV-6770-fix-post-integrations-api-credential-encryption-9766 branch October 21, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants