-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(api-service): post integrations api credential encryption #9377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-service): post integrations api credential encryption #9377
Conversation
This change prevents users from seeing sensitive integration credentials if they do not have the necessary permissions. The credentials are only returned if the user has access. Co-authored-by: dima <dima@novu.co>
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted. Your PR title is: Requirements:
Expected format: Details: PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name |
…dential-encryption-9766
…dential-encryption-9766
…ryption-9766' of https://github.com/novuhq/novu into cursor/NV-6770-fix-post-integrations-api-credential-encryption-9766
What changed? Why was the change needed?
Previously, the
POST /v1/integrations
,PUT /v1/integrations/:integrationId
, andPOST /v1/integrations/:integrationId/set-primary
API endpoints returned encrypted integration credentials. This was inconsistent with theGET /v1/integrations
endpoint, which returns unencrypted credentials.This change modifies these endpoints to return unencrypted credentials, aligning their behavior with the GET endpoint. This resolves the inconsistency and addresses the need for users (e.g., Terraform providers) to compare configured values with actual Novu values, as detailed in NV-6770.
Screenshots
N/A
Expand for optional sections
Related enterprise PR
N/A
Special notes for your reviewer
Credential decryption and return are conditional on the user having
INTEGRATION_WRITE
permissions, ensuring proper Role-Based Access Control (RBAC).Linear Issue: NV-6770