Skip to content

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Oct 20, 2025

What changed? Why was the change needed?

This PR resolves NV-6760 by preventing click event propagation within the PopoverContent component. Previously, when a popover (like the activity feed filters) was open, clicks inside it would "click through" to underlying elements (e.g., activity list rows), making the popover's interactive elements unusable. By stopping event propagation, clicks are now correctly handled only within the popover.

Screenshots

A screen recording demonstrating the original issue is available in the Linear ticket: Screen Recording 2025-10-02 at 15.03.23.mov

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

This is a centralized fix applied to the base PopoverContent component, which should resolve similar click-through issues for all popovers across the dashboard.


Linear Issue: NV-6760

Open in Cursor Open in Web

Co-authored-by: dima <dima@novu.co>
@cursor
Copy link
Contributor

cursor bot commented Oct 20, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@linear
Copy link

linear bot commented Oct 20, 2025

@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy preview added

Name Link
🔨 Latest commit 713597a
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/68f7c784677a06000990048c
😎 Deploy Preview https://deploy-preview-9376.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor Author

scopsy commented Oct 20, 2025

✅ All jobs passed

Summary: 4 successful workflows

Last updated: 2025-10-20 19:09:34 UTC

@scopsy scopsy changed the title Fix subscriber page activity feed filter click bug fix(dashboard): subscriber page activity feed filter click bug fixes NV-6760 Oct 21, 2025
@scopsy scopsy merged commit c63e76a into next Oct 21, 2025
23 of 25 checks passed
@scopsy scopsy deleted the cursor/NV-6760-fix-subscriber-page-activity-feed-filter-click-bug-916c branch October 21, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants