fix(worker,framework): email cid images fixes NV-6777 #9330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
github-actions
bot
changed the title
LetItRock
commented
Oct 8, 2025
Comment on lines
+315
to
+316
| cid: attachment.cid, | ||
| disposition: attachment.disposition, |
There was a problem hiding this comment.
the attachments cid, disposition was missing when passing this information to the providers :/
| * Additional URL schemes to allow in src, href, and other URL attributes. | ||
| * Including 'cid:' for Content-ID references used in email attachments. | ||
| */ | ||
| allowedSchemes: sanitizeTypes.defaults.allowedSchemes.concat(['cid']), |
There was a problem hiding this comment.
the <img src="cid:..." cid schema was not allowed during sanitization :/
| return JSON.parse(compiledString); | ||
| // repair the string to fix invalid JSON, it could happen in the case when the control value | ||
| // has the escaped quotes like '\"foo\"' then compiled string is not valid JSON and parse will fail | ||
| const repairedString = jsonrepair(compiledString); |
There was a problem hiding this comment.
the comment above explains the case well
| attachments: options.attachments?.map((attachment) => ({ | ||
| filename: attachment?.name, | ||
| content: attachment.file, | ||
| contentId: attachment.cid, |
LetItRock
force-pushed
the
nv-6777-fix-email-cid-images
branch
from
f9c820e to
0400d22
Compare
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Fix failing email CID image attachments. I'll describe a couple of issues in the comments.
Screenshots