refactor(api): enhance OAuth user login error handling and guidance #9299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
dollaransh17
force-pushed
the
improve/enhance-login-oauth-handling
branch
from
804de28 to
36ddcfa
Compare
dollaransh17
changed the title
- Replace TODO comment with comprehensive OAuth user error handling - Add dedicated helper method for OAuth error messaging with future extensibility - Provide clear, actionable error message directing users to correct sign-in method - Improve UX by explaining why password login fails for OAuth users - Add documentation for potential future enhancements (provider-specific guidance) This resolves the TODO comment about triggering password reset flow for OAuth users by providing better user experience through clear messaging rather than automatic password reset, which could be confusing for users who intentionally signed up with OAuth.
dollaransh17
force-pushed
the
improve/enhance-login-oauth-handling
branch
from
36ddcfa to
264ea4a
Compare
dollaransh17
changed the title
|
Closing as the PR lacks the reason or need for this change via an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the TODO comment about triggering password reset flow for OAuth users by providing better user experience through clear messaging rather than automatic password reset, which could be confusing for users who intentionally signed up with OAuth.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer