feat(dashboard,api): add/update translation key/value pairs in editor; dropdown fixes #8615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
…itor-to-translation-json
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
WalkthroughThis update introduces comprehensive translation key management features to the dashboard's email workflow editor. It adds hooks for fetching, creating, and updating translation keys and values, integrates translation key suggestions and validation into the UI, and refines tooltip and hover interactions. Several components and hooks are refactored or extended to support dynamic translation workflows. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Editor as Email Editor
participant Hooks
participant API
participant UI as UI Components
User->>Editor: Opens email workflow editor
Editor->>Hooks: useFetchTranslationKeys (workflowId)
Hooks->>API: Fetch translation keys for workflow
API-->>Hooks: Return translation keys
Hooks-->>Editor: Provide translation keys
User->>UI: Types new translation key
UI->>Hooks: useCreateTranslationKey (workflowId, key)
Hooks->>API: Create translation key in backend
API-->>Hooks: Confirm creation
Hooks-->>UI: Invalidate caches, show toast
User->>UI: Edits translation value
UI->>Hooks: useUpdateTranslationValue (workflowId, key, value)
Hooks->>API: Update translation value
API-->>Hooks: Confirm update
Hooks-->>UI: Invalidate caches, show toast
UI->>User: Shows updated translation key/value, tooltips, and suggestions
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
scopsy
approved these changes
Jul 1, 2025
Comment on lines
+167
to
+181
| const handleMouseLeave = () => { | ||
| // Small delay to allow moving to tooltip | ||
| timeoutRef.current = setTimeout(() => { | ||
| setHoveredOptionIndex(-1); | ||
| }, 150); | ||
| }; | ||
|
|
||
| const handleMouseEnter = () => { | ||
| if (timeoutRef.current) { | ||
| clearTimeout(timeoutRef.current); | ||
| timeoutRef.current = null; | ||
| } | ||
|
|
||
| setHoveredOptionIndex(index); | ||
| }; |
There was a problem hiding this comment.
Is there any other way of handling this maybe? Usually those mouseleave things are creating troubles down the read. What is the issue we try to solve with this here?
There was a problem hiding this comment.
The issue is that we need to display a tooltip with a link to translation page, therefore user should be able to actually click it.
I also don't like timeouts, there might be a more elegant way but that would require changing / creating new component for that, figuring out how to make it works and then apply it to all places where the component is used etc. I will try to revisit when there are no more higher priority items.
ChmaraX
deleted the
nv-6188-dashboard-add-keyvalue-pairs-from-editor-to-translation-json
branch
commit: |
bricehemery
pushed a commit
to jack-agency/novu
that referenced
this pull request
Jul 7, 2025
…; dropdown fixes (novuhq#8615)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Related Maily change: novuhq/maily.to#26
translation-variables.mov
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
Refactor
Chores