Skip to content

Conversation

@djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

scopsy and others added 26 commits June 23, 2025 13:51
…roved UI components

- Introduced filtering capabilities for workflow runs based on search, status, company, transaction ID, subscriber ID, and channels.
- Replaced mock data structure with IActivity for better integration with existing data models.
- Updated UI to utilize a table format for displaying workflow runs, enhancing readability and user experience.
- Added status icons and step indicators using react-icons for a more modern look.
- Implemented dynamic filtering and sorting logic to improve performance and usability.
…table

- Removed mockLogsData and getTotalLogsCount, integrating useFetchRequestLogs for fetching logs data.
- Updated logsData and totalCount to derive from API response.
- Enhanced type safety by specifying RequestLog type in logs mapping.
…vity fetching and filtering

- Removed mock data and integrated useFetchActivities for fetching activities.
- Updated filtering logic to utilize activity data, including search and status filters.
- Improved UI components for displaying activities, including loading states and channel icons.
- Enhanced type safety and modularization of helper functions for better maintainability.
- Removed unused imports and parameters for improved clarity.
- Updated filtering logic to include workflows and removed unnecessary filters.
- Enhanced type safety by aligning filter types with ActivityFilters.
- Simplified sorting logic to default to timestamp for better performance.
- Improved pagination handling by resetting displayed items on filter changes.
- Adjusted height and overflow properties for the collapsible section to improve usability.
- Simplified the main container by removing unnecessary flex properties for better layout management.
…able defaults

- Removed unused ApiTags decorator from LogsController for clarity.
- Updated environment variable validators to provide default values for ClickHouse configuration.
- Increased maximum payload size in payload sanitizer for improved data handling.
- Refactored retry logic in payload sanitizer for better readability and error handling.
…use repository structure

- Added validation rules for pagination parameters in GetRequestsDto to enforce limits and format.
- Refactored Clickhouse repository to use const assertions for operator definitions, ensuring type safety.
- Introduced validation methods for column names and operators in the BaseRepository to enhance query safety.
- Updated HttpLogRepository to include schema order by definitions for improved query flexibility.
- Enhanced httpLogSchema with engine specification and defined ORDER_BY for better query management.
- Changed statusCode from string to number in GetRequestsDto and GetRequestsCommand for improved type safety.
- Renamed numberDays to days in GetRequestsCommand and updated related logic in the use case for clarity and consistency.
- Changed status_code assignment in GetRequests use case to directly use command.statusCode for improved type consistency.
- Removed unnecessary parsing of statusCode to integer, enhancing clarity and maintaining original data type.
…logs

- Updated RequestLog DTO and related components to use createdAt instead of timestamp for improved clarity and consistency.
- Adjusted database schema and query logic to reflect the new naming convention.
- Modified logs detail and table components to display createdAt correctly, enhancing readability.
- Updated TABLE_NAME constant in HttpLogRepository to reflect the new naming convention, enhancing clarity in log management.
- Introduced LogsListBlank component to handle the case when no logs are available, improving user experience and clarity in the logs table.
- Renamed and refactored LogsDetailEmpty to RequestLogDetailEmptyState for clarity and consistency.
- Updated LogsListBlank to RequestLogsEmptyState to align with new naming conventions.
- Enhanced the empty state UI to provide clearer instructions for users when no logs are available.
- Replaced manual pagination controls with CursorPagination component for improved modularity and clarity.
- Updated useLogsUrlState hook to manage pagination state and actions, enhancing code maintainability.
- Adjusted logs table to utilize new pagination logic, streamlining the user experience when navigating logs.
@linear
Copy link

linear bot commented Jun 25, 2025

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/novuhq/novu@8590
npm i https://pkg.pr.new/novuhq/novu/@novu/providers@8590
npm i https://pkg.pr.new/novuhq/novu/@novu/shared@8590

commit: f5ba35a

- Added onLast callback to CursorPagination component for navigating to the last page.
- Updated LogsTable to utilize the new onLast handler, improving pagination controls.
- Enhanced useLogsUrlState hook to include handleLast function for managing last page navigation.
…ltering

- Changed days property to hoursAgo in GetRequestsCommand for improved clarity in time filtering.
- Added created property to GetRequestsDto to allow filtering logs based on creation time in hours.
- Updated LogsController and related components to accommodate the new hoursAgo and created parameters, enhancing log retrieval functionality.
- Updated the analytics strategy enum name for consistency and clarity.
- Refactored LogAnalytics decorator and related functions to use the new enum name.
- Improved type safety by ensuring the correct enum type is used throughout the analytics logging functionality.
- Simplified payload sanitizer function by removing unnecessary complexity, enhancing maintainability.
…arity

- Replaced HttpLog references with RequestLog across various components and services to align with new naming conventions.
- Updated GetRequests use case and related DTOs to utilize RequestLog, enhancing type consistency and clarity.
- Refactored analytics logging to use RequestLog, ensuring uniformity in log management.
- Removed obsolete HttpLog schema and repository, streamlining the codebase.
- Eliminated onLast callback from CursorPagination component to simplify pagination controls.
- Updated LogsTable to remove references to handleLast, streamlining pagination logic.
- Adjusted useLogsUrlState hook to exclude handleLast, enhancing clarity and maintainability.
@djabarovgeorge djabarovgeorge merged commit 43e1f95 into nv-6147-clickhouse-http-request-logging Jun 29, 2025
23 checks passed
@djabarovgeorge djabarovgeorge deleted the nv-6162-create-http-logs-dashboard-ui-page branch June 29, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants